[GitHub] [helix] xyuanlu edited a comment on pull request #1129: Validate instance topology configuration before let it comes online

[GitBox <gi...@apache.org>]

xyuanlu edited a comment on pull request #1129:
URL: https://github.com/apache/helix/pull/1129#issuecomment-672272081


   This PR is ready to be merged.
   
   Validate instance topology configuration before let it comes online
   
   Helix does not check if an instance's topology config is defined correctly when the instance is added or joins cluster. This will cause Helix to fail the rebalance. This change adds the sanity check when
   - Instance joins cluster as liveInstance
   - User update InstanceConfig using RestApi
   - Controller prepares the topology structure for rebalance
   This change also did come code clean up and centralized the logic for topology sanity check.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org