You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2010/07/13 01:10:50 UTC
[jira] Created: (PIG-1497) Mandatory rule PartitionFilterOptimizer
Mandatory rule PartitionFilterOptimizer
---------------------------------------
Key: PIG-1497
URL: https://issues.apache.org/jira/browse/PIG-1497
Project: Pig
Issue Type: Sub-task
Components: impl
Affects Versions: 0.8.0
Reporter: Daniel Dai
Fix For: 0.8.0
Need to migrate PartitionFilterOptimizer to new logical optimizer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1497) Mandatory rule
PartitionFilterOptimizer
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900100#action_12900100 ]
Richard Ding commented on PIG-1497:
-----------------------------------
Looks good. A few comments:
In _PartitionFilterPushDown_:
* In _check_ method, why changes the condition from
{code}
if(... || sucs.size() != 1 || ...) {
{code}
to
{code}
if(... || succeds.size() == 0 || ...)
{code}
* In _transform_ method, the original code
{code}
// remove this filter from the plan
mPlan.removeAndReconnect(loFilter);
{code}
is replaced by its own implementation. It seems better to also migrate the _removeAndReconnect_ to the new _OperatorPlan_ since the logic there is more complicated (keeping the order of connections).
* The javadoc for the class isn't migrated.
* Several variables (e.g. loadFunc, loLoad, loFilter, ...) now have scope within the _PartitionFilterPushDownTransformer_ class, so it would be better to put them inside the transformer class.
In addition,
* Need to remove all the tabs from the files and replace them with 4 spaces.
* Several unit tests now fail due to the dependency on other jiras.
> Mandatory rule PartitionFilterOptimizer
> ---------------------------------------
>
> Key: PIG-1497
> URL: https://issues.apache.org/jira/browse/PIG-1497
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Affects Versions: 0.8.0
> Reporter: Daniel Dai
> Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1497-0.patch
>
>
> Need to migrate PartitionFilterOptimizer to new logical optimizer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1497) Mandatory rule PartitionFilterOptimizer
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xuefu Zhang updated PIG-1497:
-----------------------------
Status: Patch Available (was: Open)
> Mandatory rule PartitionFilterOptimizer
> ---------------------------------------
>
> Key: PIG-1497
> URL: https://issues.apache.org/jira/browse/PIG-1497
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Affects Versions: 0.8.0
> Reporter: Daniel Dai
> Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1497-0.patch
>
>
> Need to migrate PartitionFilterOptimizer to new logical optimizer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1497) Mandatory rule PartitionFilterOptimizer
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xuefu Zhang updated PIG-1497:
-----------------------------
Attachment: jira-1497-0.patch
> Mandatory rule PartitionFilterOptimizer
> ---------------------------------------
>
> Key: PIG-1497
> URL: https://issues.apache.org/jira/browse/PIG-1497
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Affects Versions: 0.8.0
> Reporter: Daniel Dai
> Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1497-0.patch
>
>
> Need to migrate PartitionFilterOptimizer to new logical optimizer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (PIG-1497) Mandatory rule PartitionFilterOptimizer
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich reassigned PIG-1497:
-----------------------------------
Assignee: Xuefu Zhang
> Mandatory rule PartitionFilterOptimizer
> ---------------------------------------
>
> Key: PIG-1497
> URL: https://issues.apache.org/jira/browse/PIG-1497
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Affects Versions: 0.8.0
> Reporter: Daniel Dai
> Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
>
> Need to migrate PartitionFilterOptimizer to new logical optimizer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1497) Mandatory rule PartitionFilterOptimizer
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1497:
----------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
Did a combined test-patch with PIG-1514:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 80 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] -1 release audit. The applied patch generated 443 release audit warnings (more than the trunk's current 433 warnings).
All new source code have the license header.
Patch committed. Thanks Xuefu!
> Mandatory rule PartitionFilterOptimizer
> ---------------------------------------
>
> Key: PIG-1497
> URL: https://issues.apache.org/jira/browse/PIG-1497
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Affects Versions: 0.8.0
> Reporter: Daniel Dai
> Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1497-0.patch
>
>
> Need to migrate PartitionFilterOptimizer to new logical optimizer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.