You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/11/18 01:08:27 UTC
[GitHub] [nifi] gresockj opened a new pull request #5532: NIFI-9386: Adding status task schedule to Stateless engine config
gresockj opened a new pull request #5532:
URL: https://github.com/apache/nifi/pull/5532
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
Adds `nifi.stateless.status.task.schedule` to the NiFi Stateless Engine configuration, allowing the `LogComponentStatuses` background task schedule to be configurable or omitted altogether if the property is blank. Exposed this setting to `ExecuteStateless` under a new property named `Status Task Schedule`.
If the property is omitted completely from the stateless.properties configuration, a default of 1 minute (the previous value) is used. If the property is empty, the status logging task is not scheduled at all.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] gresockj commented on pull request #5532: NIFI-9386: Adding status task schedule to Stateless engine config
Posted by GitBox <gi...@apache.org>.
gresockj commented on pull request #5532:
URL: https://github.com/apache/nifi/pull/5532#issuecomment-978026738
Thanks for the feedback, @markap14! I believe I addressed everything in my latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on a change in pull request #5532: NIFI-9386: Adding status task schedule to Stateless engine config
Posted by GitBox <gi...@apache.org>.
markap14 commented on a change in pull request #5532:
URL: https://github.com/apache/nifi/pull/5532#discussion_r751864338
##########
File path: nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/main/java/org/apache/nifi/stateless/engine/StatelessEngine.java
##########
@@ -70,4 +72,6 @@
FlowFileEventRepository getFlowFileEventRepository();
CounterRepository getCounterRepository();
+
+ Duration getStatusTaskSchedule();
Review comment:
Would argue this isn't really returning a schedule, but rather a frequency or a scheduling period - thoughts on calling this getStatusTaskSchedulingPeriod() or getStatusTaskFrequency()?
##########
File path: nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/test/java/org/apache/nifi/stateless/engine/TestStandardStatelessEngine.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.stateless.engine;
+
+import org.junit.Test;
+
+import java.time.Duration;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+
+public class TestStandardStatelessEngine {
+
+ @Test
+ public void parseDurationTooSmall() {
+ // Falls back to default 1 minute if invalid
+ assertEquals(Duration.ofMinutes(1), StandardStatelessEngine.parseDuration("999 ms"));
+ }
+
+ @Test
+ public void parseDurationInvalid() {
+ // Falls back to default 1 minute if invalid
+ assertEquals(Duration.ofMinutes(1), StandardStatelessEngine.parseDuration("1 nonsense"));
+ }
+
+ @Test
+ public void parseDurationValid() {
+ assertEquals(Duration.ofSeconds(1), StandardStatelessEngine.parseDuration("1 sec"));
+ assertEquals(Duration.ofHours(24), StandardStatelessEngine.parseDuration("24 hours"));
Review comment:
Perhaps worth verifying a value of "5 secs " - i.e., a valid value with leading/trailing whitespace - happens frequently in .properties files and can be really confusing to understand what's wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on a change in pull request #5532: NIFI-9386: Adding status task schedule to Stateless engine config
Posted by GitBox <gi...@apache.org>.
markap14 commented on a change in pull request #5532:
URL: https://github.com/apache/nifi/pull/5532#discussion_r751861798
##########
File path: nifi-nar-bundles/nifi-stateless-processor-bundle/nifi-stateless-processor/src/main/java/org/apache/nifi/processors/stateless/ExecuteStateless.java
##########
@@ -850,6 +862,8 @@ private StatelessEngineConfiguration createEngineConfiguration(final ProcessCont
contentRepoDirectory = null;
}
+ final String statusTaskSchedule = context.getProperty(STATUS_TASK_SCHEDULE).isSet() ? context.getProperty(STATUS_TASK_SCHEDULE).getValue() : null;
Review comment:
Can just use `final String statusTaskSchedule = context.getProperty(STATUS_TASK_SCHEDULE).getValue()` no? If not set, will be `null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #5532: NIFI-9386: Adding status task schedule to Stateless engine config
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #5532:
URL: https://github.com/apache/nifi/pull/5532#issuecomment-972465818
Also noticed a checkstyle violation causing the builds to fail :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #5532: NIFI-9386: Adding status task schedule to Stateless engine config
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #5532:
URL: https://github.com/apache/nifi/pull/5532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] gresockj commented on a change in pull request #5532: NIFI-9386: Adding status task schedule to Stateless engine config
Posted by GitBox <gi...@apache.org>.
gresockj commented on a change in pull request #5532:
URL: https://github.com/apache/nifi/pull/5532#discussion_r751863197
##########
File path: nifi-nar-bundles/nifi-stateless-processor-bundle/nifi-stateless-processor/src/main/java/org/apache/nifi/processors/stateless/ExecuteStateless.java
##########
@@ -850,6 +862,8 @@ private StatelessEngineConfiguration createEngineConfiguration(final ProcessCont
contentRepoDirectory = null;
}
+ final String statusTaskSchedule = context.getProperty(STATUS_TASK_SCHEDULE).isSet() ? context.getProperty(STATUS_TASK_SCHEDULE).getValue() : null;
Review comment:
Whoops, yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #5532: NIFI-9386: Adding status task schedule to Stateless engine config
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #5532:
URL: https://github.com/apache/nifi/pull/5532#issuecomment-992353091
Merged, thanks @gresockj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] gresockj commented on a change in pull request #5532: NIFI-9386: Adding status task schedule to Stateless engine config
Posted by GitBox <gi...@apache.org>.
gresockj commented on a change in pull request #5532:
URL: https://github.com/apache/nifi/pull/5532#discussion_r751866576
##########
File path: nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/main/java/org/apache/nifi/stateless/engine/StatelessEngine.java
##########
@@ -70,4 +72,6 @@
FlowFileEventRepository getFlowFileEventRepository();
CounterRepository getCounterRepository();
+
+ Duration getStatusTaskSchedule();
Review comment:
Fair enough -- I like the latter as it's shorter -- though what about getStatusTaskInterval? This would match the term used in nifi.properties in a few places already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org