You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2016/12/14 00:03:38 UTC

zeppelin git commit: [HOT FIX] Fix broken display_formula.png by using relative path

Repository: zeppelin
Updated Branches:
  refs/heads/master 9b346de6a -> 641a641c3


[HOT FIX] Fix broken display_formula.png by using relative path

### What is this PR for?
Currently `display_formula.png` (added by #1606) is broken in here: http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/displaysystem/basicdisplaysystem.html#mathematical-expressions

Fixed it by using relative path for the image. But have no idea why the other image files are not broken in that page.

### What type of PR is it?
Documentation | Hot Fix

### Todos
* [ ] - Task

### What is the Jira issue?
N/A

### How should this be tested?
It can't be reproduced using docs dev mode. Needs to be tested with below steps.

```
1) build gh-pages (website) branch
JEKYLL_ENV=production bundle exec jekyll build
cp -r _site/ /tmp/zeppelin_website/
mkdir -p /tmp/zeppelin_website/docs/0.7.0-SNAPSHOT

2) build this patch (docs) and copy it under docs/0.7.0-SNAPSHOT of website
cd docs
bundle exec jekyll build --safe
cp -r _site/ /tmp/zeppelin_website/0.7.0-SNAPSHOT/

3) start httpserver and browse http://localhost:8000/docs/0.7.0-SNAPSHOT/
cd /tmp/zeppelin_website
python -m SimpleHTTPServer
```

### Screenshots (if appropriate)
**Before**
 - In the official website
<img width="938" alt="screen shot 2016-12-13 at 7 07 27 pm" src="https://cloud.githubusercontent.com/assets/10060731/21136061/72c230b6-c167-11e6-9805-12d6f11f3270.png">

```
GET http://zeppelin.apache.org/assets/themes/zeppelin/img/screenshots/display_formula.png 404 (Not Found)
```

**After**
 - test locally using same with production path
<img width="877" alt="screen shot 2016-12-13 at 7 09 42 pm" src="https://cloud.githubusercontent.com/assets/10060731/21136136/bbff660e-c167-11e6-9ed3-384e609886fe.png">

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?

Author: AhyoungRyu <fb...@hanmail.net>

Closes #1752 from AhyoungRyu/fix-img-path and squashes the following commits:

4be330b [AhyoungRyu] Fix broken display_formula.png by using relative path


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/641a641c
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/641a641c
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/641a641c

Branch: refs/heads/master
Commit: 641a641c314f0a4b17b7c8c91f543678c9915ac1
Parents: 9b346de
Author: AhyoungRyu <fb...@hanmail.net>
Authored: Tue Dec 13 19:01:21 2016 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Tue Dec 13 16:03:29 2016 -0800

----------------------------------------------------------------------
 docs/displaysystem/basicdisplaysystem.md | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/641a641c/docs/displaysystem/basicdisplaysystem.md
----------------------------------------------------------------------
diff --git a/docs/displaysystem/basicdisplaysystem.md b/docs/displaysystem/basicdisplaysystem.md
index 78f9b30..7c42432 100644
--- a/docs/displaysystem/basicdisplaysystem.md
+++ b/docs/displaysystem/basicdisplaysystem.md
@@ -27,37 +27,37 @@ limitations under the License.
 
 By default, Apache Zeppelin prints interpreter response as a plain text using `text` display system.
 
-<img src="/assets/themes/zeppelin/img/screenshots/display_text.png" />
+<img src="../assets/themes/zeppelin/img/screenshots/display_text.png" />
 
 You can explicitly say you're using `text` display system.
 
-<img src="/assets/themes/zeppelin/img/screenshots/display_text1.png" />
+<img src="../assets/themes/zeppelin/img/screenshots/display_text1.png" />
 
 ## Html
 
 With `%html` directive, Zeppelin treats your output as HTML
 
-<img src="/assets/themes/zeppelin/img/screenshots/display_html.png" />
+<img src="../assets/themes/zeppelin/img/screenshots/display_html.png" />
 
 ### Mathematical expressions
 HTML display system automatically formats mathematical expression using [MathJax](https://www.mathjax.org/). You can use
 `\\( INLINE EXPRESSION \\)` and `$$ EXPRESSION $$` to format. For example
 
-<img src="/assets/themes/zeppelin/img/screenshots/display_formula.png" />
+<img src="../assets/themes/zeppelin/img/screenshots/display_formula.png" />
 
 
 ## Table
 
-If you have data that row separated by '\n' (newline) and column separated by '\t' (tab) with first row as header row, for example
+If you have data that row separated by `\n` (newline) and column separated by `\t` (tab) with first row as header row, for example
 
-<img src="/assets/themes/zeppelin/img/screenshots/display_table.png" />
+<img src="../assets/themes/zeppelin/img/screenshots/display_table.png" />
 
 You can simply use `%table` display system to leverage Zeppelin's built in visualization.
 
-<img src="/assets/themes/zeppelin/img/screenshots/display_table1.png" />
+<img src="../assets/themes/zeppelin/img/screenshots/display_table1.png" />
 
 If table contents start with `%html`, it is interpreted as an HTML.
 
-<img src="/assets/themes/zeppelin/img/screenshots/display_table_html.png" />
+<img src="../assets/themes/zeppelin/img/screenshots/display_table_html.png" />
 
 > **Note :** Display system is backend independent.