You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by chitin <gi...@git.apache.org> on 2016/11/07 02:45:10 UTC
[GitHub] incubator-eagle pull request #612: EAGLE-728 Application can't load applicat...
GitHub user chitin opened a pull request:
https://github.com/apache/incubator-eagle/pull/612
EAGLE-728 Application can't load application.properties when running local mode
EAGLE-728 Application can't load application.properties when running local mode
- Use hard code, and overwrite it if user passes this configuration form web ui.
https://issues.apache.org/jira/browse/EAGLE-728
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chitin/incubator-eagle EAGLE-728-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/612.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #612
----
commit ab6ae575dc53ad65766b359422d26e44f7783476
Author: chitin <ch...@gmail.com>
Date: 2016-11-07T02:27:21Z
EAGLE-728 Application can't load application.properties when running local mode
- Use hard code, and overwrite it if user passes this configuration form web ui.
https://issues.apache.org/jira/browse/EAGLE-728
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #612: EAGLE-728 Application can't load applicat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/612
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #612: EAGLE-728 Application can't load applicat...
Posted by wujinhu <gi...@git.apache.org>.
Github user wujinhu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/612#discussion_r86710130
--- Diff: eagle-jpm/eagle-hadoop-queue/src/main/resources/META-INF/providers/org.apache.eagle.hadoop.queue.HadoopQueueRunningAppProvider.xml ---
@@ -47,6 +47,12 @@
<description>interval seconds of fetching metric from resource manager</description>
<value>10</value>
</property>
+ <property>
+ <name>job.name.normalization.rules.key</name>
+ <displayName>Job Name Normalization Rules Key</displayName>
+ <description>User use -Dkey=job name normalization rules</description>
+ <value>^(.*)[0-9]{4}/[0-9]{2}/[0-9]{2}/[0-9]{2}$ => $1~ ; ^(oozie:launcher):T=(.*):W=(.*):A=(.*):ID=(?:.*)$ => $1-$2-$3-$4~ ; ^(.*)([0-9]{10})$ => $1~ ; ^[0-9a-z]{8}-[0-9a-z]{4}-[0-9a-z]{4}-[0-9a-z]{4}-[0-9a-z]{12}$ => uuid~ ; ^(.*)(?:[0-9]{8}/[0-9]{2}_[0-9]{2})$ => $1~</value>
+ </property>
</configuration>
--- End diff --
Please remove this configuration from these Provider xml files. Since we have 'Custom' function so that advanced users can add other configurations(like this) if they want.
If user passes this custom defined configuration, it will override the predefined value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #612: EAGLE-728 Application can't load applicat...
Posted by wujinhu <gi...@git.apache.org>.
Github user wujinhu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/612#discussion_r86709972
--- Diff: eagle-jpm/eagle-jpm-util/src/main/java/org/apache/eagle/jpm/util/JobNameNormalization.java ---
@@ -64,7 +67,7 @@ private JobNameNormalization() {
// load normalization rules
Config conf = ConfigFactory.load();
--- End diff --
Please remove this line(Config conf = ConfigFactory.load();) from code. Since our application is a storm topology, it will be better if we pass configure to it when we initialize it so that it won't load dynamically.
Please do a simple refactor and just pass Config object to this class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---