You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2023/08/23 03:07:06 UTC
[GitHub] [incubator-uniffle] zuston opened a new pull request, #1167: [#889] improvement: make ZSTD as the default compression type
zuston opened a new pull request, #1167:
URL: https://github.com/apache/incubator-uniffle/pull/1167
### What changes were proposed in this pull request?
make `ZSTD` as the default compression type to replace `LZ4`
### Why are the changes needed?
Fix: #889
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
1. existing UTs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #1167: [#889] improvement: make `ZSTD` as the default compression type
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1167:
URL: https://github.com/apache/incubator-uniffle/pull/1167#issuecomment-1689212138
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1167?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1167](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1167?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a5d96c8) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/f86415609e65182e0e938fc223e79fb50835b91e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f864156) will **increase** coverage by `2.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #1167 +/- ##
============================================
+ Coverage 53.61% 55.61% +2.00%
+ Complexity 2574 2106 -468
============================================
Files 391 322 -69
Lines 22366 14158 -8208
Branches 1876 1274 -602
============================================
- Hits 11991 7874 -4117
+ Misses 9665 5863 -3802
+ Partials 710 421 -289
```
| [Files Changed](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rg/apache/uniffle/common/config/RssClientConf.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9jb25maWcvUnNzQ2xpZW50Q29uZi5qYXZh) | `98.79% <100.00%> (ø)` | |
... and [71 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1167/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#889] improvement: make `ZSTD` as the default compression type [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston closed pull request #1167: [#889] improvement: make `ZSTD` as the default compression type
URL: https://github.com/apache/incubator-uniffle/pull/1167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #1167: [#889] improvement: make `ZSTD` as the default compression type
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #1167:
URL: https://github.com/apache/incubator-uniffle/pull/1167#issuecomment-1690985101
+1, is the failed tests related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #1167: [#889] improvement: make `ZSTD` as the default compression type
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1167:
URL: https://github.com/apache/incubator-uniffle/pull/1167#issuecomment-1691120930
> +1, is the failed tests related?
I think yes. I will fix if I have time.
Feel feel to pick up if someone is interested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org