[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

["Dawid Weiss (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251599#comment-17251599 ] 

Dawid Weiss commented on LUCENE-9570:
-------------------------------------

Just a note of the problematic code that I had to manually adjust. 

* long single-line comments after the braces; formatter tries to keep these after the brace, sometimes forcing line breaks. These commands should be moved manually to precede the statement.
{code}
-    boolean[] mustRewriteHolder = {false}; // boolean wrapped in 1-ary array so it's mutable from inner class
+    boolean[] mustRewriteHolder = {
+      false
+    }; // boolean wrapped in 1-ary array so it's mutable from inner class
{code}

Should be:
{code}
// boolean wrapped in 1-ary array so it's mutable from inner class
boolean[] mustRewriteHolder = {false};
{code}

> Review code diffs after automatic formatting and correct problems before it is applied
> --------------------------------------------------------------------------------------
>
>                 Key: LUCENE-9570
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9570
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Blocker
>
> Review and correct all the javadocs before they're messed up by automatic formatting. Apply project-by-project, review diff, correct. Lots of diffs but it should be relatively quick.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org