You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2016/07/21 14:46:12 UTC
[GitHub] flink pull request #2279: [FLINK-4229] Only start JMX server when port is sp...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/2279
[FLINK-4229] Only start JMX server when port is specified
The JMX reporter now only starts an extra server if a port (or port range) was specified. Otherwise, it will just have the default local JMX capabilities.
R: @StephanEwen
R: @zentol
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink jmx-no-server
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2279.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2279
----
commit 89fc415ee8b882ac67dc34be41c98811e35dae98
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2016-07-21T14:44:06Z
[FLINK-4229] Only start JMX server when port is specified
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2279: [FLINK-4229] Only start JMX server when port is sp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2279: [FLINK-4229] Only start JMX server when port is specified
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2279
@StephanEwen did you merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2279: [FLINK-4229] Only start JMX server when port is specified
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2279
Looks good, will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2279: [FLINK-4229] Only start JMX server when port is sp...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2279#discussion_r71722866
--- Diff: flink-core/src/test/java/org/apache/flink/metrics/reporter/JMXReporterTest.java ---
@@ -88,7 +88,7 @@ public void testPortConflictHandling() throws Exception {
JMXReporter rep2 = new JMXReporter();
Configuration cfg1 = new Configuration();
- cfg1.setString(ConfigConstants.METRICS_REPORTER_ARGUMENTS, "-port 9020-9035");
+ cfg1.setString("port", "9020-9035");
--- End diff --
Got it, it is the already parsed sub-config.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2279: [FLINK-4229] Only start JMX server when port is sp...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2279#discussion_r71720105
--- Diff: flink-core/src/test/java/org/apache/flink/metrics/reporter/JMXReporterTest.java ---
@@ -88,7 +88,7 @@ public void testPortConflictHandling() throws Exception {
JMXReporter rep2 = new JMXReporter();
Configuration cfg1 = new Configuration();
- cfg1.setString(ConfigConstants.METRICS_REPORTER_ARGUMENTS, "-port 9020-9035");
+ cfg1.setString("port", "9020-9035");
--- End diff --
The change of only starting a server when the ports are present should not change the config keys, correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2279: [FLINK-4229] Only start JMX server when port is specified
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2279
Was waiting for travis after the rebase, but got the green light now. Will push it to master...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---