You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Carsten Ziegeler (Jira)" <ji...@apache.org> on 2021/12/21 14:11:00 UTC

[jira] [Commented] (SLING-11029) OSGiServiceInjector.getService() should rely on framework

    [ https://issues.apache.org/jira/browse/SLING-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463268#comment-17463268 ] 

Carsten Ziegeler commented on SLING-11029:
------------------------------------------

Of course, that simplification does only work if the filter is null

> OSGiServiceInjector.getService() should rely on framework
> ---------------------------------------------------------
>
>                 Key: SLING-11029
>                 URL: https://issues.apache.org/jira/browse/SLING-11029
>             Project: Sling
>          Issue Type: Improvement
>          Components: Sling Models
>    Affects Versions: Models Implementation 1.5.0
>            Reporter: Carsten Ziegeler
>            Priority: Major
>             Fix For: Models Implementation 1.5.2
>
>
> Looking at https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java#L102 it seems to get all service references, sort them and then uses the one with the highest ranking.
> However BundleContext#getServiceReference() does exactly that, so it can be directly used



--
This message was sent by Atlassian Jira
(v8.20.1#820001)