You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by thiagokronig <gi...@git.apache.org> on 2015/05/14 23:35:33 UTC
[GitHub] activemq-artemis pull request: Make Topology non-serializable and ...
GitHub user thiagokronig opened a pull request:
https://github.com/apache/activemq-artemis/pull/262
Make Topology non-serializable and also improve constructor
Topology serialization is already broken at this point, as its `topologyListeners` are not Serializable themselves.
Also, all the `executor` logic was simplified by making it `final`, defined at the constructor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thiagokronig/activemq-artemis topology
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/262.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #262
----
commit 59e4f3441571fcc55458628fc21b20c72c816f67
Author: Thiago Kronig <ca...@uolinc.com>
Date: 2015-05-13T23:59:54Z
Topology should not be Serializable
Topology serialization is already broken at this point, as its topologyListeners
are not Serializable themselves.
commit 3c6e213f66e661760aebb6902e298e56a84b2b75
Author: Thiago Kronig <ca...@uolinc.com>
Date: 2015-05-14T00:07:23Z
Topology executor should be final
commit 545e67fc9675ebb24d559e88386408c15f0adc16
Author: Thiago Kronig <ca...@uolinc.com>
Date: 2015-05-13T23:50:30Z
Fix typos and string concat in Topology
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Make Topology non-serializable and ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/262#issuecomment-102180239
I'm running a full testsuite as well just in case
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] activemq-artemis pull request: Make Topology
non-serializable and ...
Posted by Thiago Kronig <th...@gmail.com>.
Of course. Will do it on Linux tomorrow.
On Thu, May 14, 2015, 19:31 clebertsuconic <gi...@git.apache.org> wrote:
> Github user clebertsuconic commented on the pull request:
>
>
> https://github.com/apache/activemq-artemis/pull/262#issuecomment-102180201
>
> looks nice... but it seems to be a regression on the extra-tests:
>
>
> https://builds.apache.org/job/ActiveMQ-Artemis-PR-Build/342/testReport/junit/org.apache.activemq.artemis.tests.extras.byteman/ClusteredGroupingTest/test3serversLocalGoesDown/
>
> you have to add the profile extra-tests for this byteman to work. Can
> you take a look?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] activemq-artemis pull request: Make Topology non-serializable and ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/262#issuecomment-102180201
looks nice... but it seems to be a regression on the extra-tests:
https://builds.apache.org/job/ActiveMQ-Artemis-PR-Build/342/testReport/junit/org.apache.activemq.artemis.tests.extras.byteman/ClusteredGroupingTest/test3serversLocalGoesDown/
you have to add the profile extra-tests for this byteman to work. Can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: chages made after a few performance...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Make Topology non-serializable and ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Make Topology non-serializable and ...
Posted by thiagokronig <gi...@git.apache.org>.
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/262#issuecomment-102564693
I couldn't the failure in both linux and windows, using `mvn clean test -Pextra-tests`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---