[jira] [Commented] (STORM-354) Allow users to pass TEST-TIMEOUT-MS as param for complete-topology

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287546#comment-14287546 ] 

ASF GitHub Bot commented on STORM-354:
--------------------------------------

Github user vkaggalumn commented on the pull request:

    https://github.com/apache/storm/pull/122#issuecomment-71032607
  
    Thanks @harshach.
    
    If I am reading the documentation right, I see the following which instructs how to build the storm code base with the STORM_TEST_TIMEOUT_MS set? Being a new user, I am wondering about the this - How should we be setting this (STORM_TEST_TIMEOUT_MS) when using Eclipse to run our tests in our storm project? Or am I not reading this right?
    
    <pre>
    # Build the code and run the tests, with specifying default test timeout (in millisecond)
    $ export STORM_TEST_TIMEOUT_MS=10000
    $ mvn clean install
    </pre>
    
    Any pointers would be greatly appreciated.
    
    Many thanks!


> Allow users to pass TEST-TIMEOUT-MS as param for complete-topology
> ------------------------------------------------------------------
>
>                 Key: STORM-354
>                 URL: https://issues.apache.org/jira/browse/STORM-354
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 0.9.2-incubating
>            Reporter: Aaron Levin
>            Assignee: Aaron Levin
>            Priority: Minor
>              Labels: test
>             Fix For: 0.9.3
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> It would be nice if complete-topology allowed a user to pass in the default timeout as a parameter (rather than just setting it as 5000ms). I had a test that kept failing by taking too long.
> This PR adds functionality without breaking any existing code. Tests pass.
> (PS - not sure if this is the proper way to submit a PR for an apache project. I'm open to feedback. Thanks)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)