You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/18 09:46:20 UTC
[GitHub] [flink] hequn8128 edited a comment on issue #9141:
[FLINK-12249][table] Fix type equivalence check problems for Window
Aggregates
hequn8128 edited a comment on issue #9141: [FLINK-12249][table] Fix type equivalence check problems for Window Aggregates
URL: https://github.com/apache/flink/pull/9141#issuecomment-512745137
@dawidwys Thanks for your comments. I think you are right.
We had a discussion just now. (with @godfreyhe @wuchong @sunjincheng121 ) We think that, to solve the problem fundamentally, the current window aggregate should not extend from `org.apache.calcite.rel.core.Aggregate`, instead it should extend from `SingleRel`. This makes sure the right semantics of window aggregate.
To correct this, the changes may be somehow very large as there are many existing window related rules. Also, this is a problem a long time ago and the probability of occurrence is relatively small.
Considering the reasons above, I think it would be good if we can fix this issue later after release-1.9?
What do you think? @dawidwys @godfreyhe @wuchong @sunjincheng121
Best, Hequn
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services