[GitHub] [arrow-datafusion] kmitchener commented on pull request #3517: fix divide by zero not throwing proper error for decimal

[GitBox <gi...@apache.org>]

kmitchener commented on PR #3517:
URL: https://github.com/apache/arrow-datafusion/pull/3517#issuecomment-1249655911

   f64 also doesn't have the precision to do Decimal128 math. I'll add another issue around fixing the math for Decimal128 so it uses i128 instead of floats. I first attempted to fix that here but I think fixing that might be more complicated than it looks. I think we can handle that separately and just focus this fix on the divide by zero error. Note also that the full precision of decimal literals is not available from SQL because the SQL planner converts all literals to floats. (not a problem in this case obviously, but would be for literals using the full 38 digits.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org