You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by d2r <gi...@git.apache.org> on 2014/06/17 18:01:57 UTC

[GitHub] incubator-storm pull request: [STORM-357] Cleans workers-users fil...

GitHub user d2r opened a pull request:

    https://github.com/apache/incubator-storm/pull/144

    [STORM-357] Cleans workers-users file only when rmr is successful

    We do not check the exit code of the "worker launcher" script, but even if we did, it returns 255 indiscriminately preventing us from distinguishing failure modes.
    
    This change adds a specialized function for calling "rmr" that throws an exception if we find in fact that the worker root dir was not removed after the script returns. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/d2r/incubator-storm STORM-357

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-storm/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #144
    
----
commit d1ba4fc4acdadd5e5e138395bdc5892dfdb88bff
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2014-06-17T15:56:51Z

    Do not clean up user file when rmr is unsuccessful

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-storm pull request: [STORM-357] Cleans workers-users fil...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-storm/pull/144


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-storm pull request: [STORM-357] Cleans workers-users fil...

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:

    https://github.com/apache/incubator-storm/pull/144#issuecomment-46347409
  
    Thanks Derek,  The change looks good.  I ran some manual tests and it looks to be working well. +1. I'll merge this into security


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---