[GitHub] [ignite] ivandasch commented on a diff in pull request #10430: IGNITE-18198 Implement snapshots of caches with disk page compression.

[GitBox <gi...@apache.org>]

ivandasch commented on code in PR #10430:
URL: https://github.com/apache/ignite/pull/10430#discussion_r1054297373


##########
modules/compress/src/main/java/org/apache/ignite/internal/processors/compress/CompressionProcessorImpl.java:
##########
@@ -170,6 +177,28 @@ private ByteBuffer doCompactPage(ByteBuffer page, int pageSize) throws IgniteChe
         return compactPage;
     }
 
+    /** Check if filesystem actually supports punching holes. */
+    private void checkPunchHole(Path storagePath, int fsBlockSz) throws IgniteException {
+        Path testFile = storagePath.resolve("punch_hole_" + UUID.randomUUID() + ".test");

Review Comment:
   Because it will be created in /tmp. We should check exactly the given path



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org