[GitHub] [spark] gaborgsomogyi commented on a change in pull request #27744: [SPARK-30992][DSTREAMS] Arrange scattered config of streaming module

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on a change in pull request #27744: [SPARK-30992][DSTREAMS] Arrange scattered config of streaming module
URL: https://github.com/apache/spark/pull/27744#discussion_r387657948
 
 

 ##########
 File path: streaming/src/main/scala/org/apache/spark/streaming/util/StateMap.scala
 ##########
 @@ -61,8 +62,7 @@ private[streaming] object StateMap {
   def empty[K, S]: StateMap[K, S] = new EmptyStateMap[K, S]
 
   def create[K: ClassTag, S: ClassTag](conf: SparkConf): StateMap[K, S] = {
-    val deltaChainThreshold = conf.getInt("spark.streaming.sessionByKey.deltaChainThreshold",
-      DELTA_CHAIN_LENGTH_THRESHOLD)
+    val deltaChainThreshold = conf.get(SESSION_BY_KEY_DELTA_CHAIN_THRESHOLD)
 
 Review comment:
   Do the newly defined config's default value and the mentioned other places have to keep the same value? I mean if one change the one should the others be changed? (now the value defined in 2 distinct places)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org