[jira] Resolved: (SMXCOMP-461) Fix smx-cxf-bc consumer timeout property JavaDoc and code interpretation

["Freeman Fang (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/activemq/browse/SMXCOMP-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Freeman Fang resolved SMXCOMP-461.
----------------------------------

       Resolution: Fixed
    Fix Version/s: servicemix-cxf-bc-2009.01
                   3.2.4

commit fix
http://svn.apache.org/viewvc?rev=746879&view=rev for 3.2 branch
http://svn.apache.org/viewvc?rev=746877&view=rev for servicemix-cxf-bc component project

> Fix smx-cxf-bc consumer timeout property JavaDoc and code interpretation
> ------------------------------------------------------------------------
>
>                 Key: SMXCOMP-461
>                 URL: https://issues.apache.org/activemq/browse/SMXCOMP-461
>             Project: ServiceMix Components
>          Issue Type: Bug
>    Affects Versions: servicemix-cxf-bc-2008.01
>            Reporter: Ron Gavlin
>            Assignee: Freeman Fang
>             Fix For: 3.2.4, servicemix-cxf-bc-2009.01
>
>
> The current JavaDoc for the timeout property is below. 
>     /**
>           * Specifies the interval for which the endpoint will wait for a 
>           * response, This is specified in seconds.
>           *
>           * @param  timeout the number of millis to wait for a response
>           * @org.apache.xbean.Property description="the number of millis the endpoint will wait for a response. The default is 1 hour."
>           **/
>     public void setTimeout(long timeout) {
>         this.timeout = timeout;
>     }
> Here, some of the documentation states the timeout unit is seconds and the other part states it is milliseconds. It also states the default timeout is 1 hour when it is really 0 (unlimited).
> Furthermore, after reviewing the CxfBcConsumer.java code, it appears the code may be inconsistent as well. The deliveryChannel.sendSync(timeout) uses the timeout property as is (indicating it expects the unit of measure to be milliseconds). However, the CXF continuation.suspend(timeout * 1000) indicates it expects the unit of measure to be seconds. 
> This inconsistency should be resolved ASAP.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.