You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/12/05 02:08:03 UTC

[GitHub] fabianmenges opened a new pull request #4005: [BUGFIX]: Java scripts max int is 2^53 - 1, longs are bigger

fabianmenges opened a new pull request #4005: [BUGFIX]: Java scripts max int is 2^53 - 1, longs are bigger
URL: https://github.com/apache/incubator-superset/pull/4005
 
 
   Twitter uses very long IDs for entities. This causes issues because Java Script can not handle these long IDs and will **round** them by treating them as a float. 
   
   This is a very hack fix, that will just convert every integer that is longer than the longest integer supported by JS to a string for both SQL Lab as well as the default table visualization. 
   This works since both python and JS are dynamically typed, but its not great.
   
   Any suggestions how we should handle this correctly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services