[GitHub] [incubator-yunikorn-core] sunilgovind commented on pull request #196: YUNIKORN-317. [Design Doc] Cache/Scheduler modules need to be combined to a single module

[GitBox <gi...@apache.org>]

sunilgovind commented on pull request #196:
URL: https://github.com/apache/incubator-yunikorn-core/pull/196#issuecomment-678608278


   Based on the size of the patch and the approach, it is better we do more tests and ensure the stability is maintained. I think it's worth to keep going with a single patch where all changes goes in and the PR is enough to test all. (Rather compared to 8 to 10 patches in a branch). Usually we go with branch model but this is a complete overhaul based on my initial reviews. So my vote is having a bare minimum single PR where most of the work is done and get that tested and reviewed well before pushing to master. 
   
   I think an approach like this will slow down other critical feature development. As a community we need to agree whether this is fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org