[kudu] branch master updated: KUDU-3451 fix memory leak in scan_token-test

[zh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zhangyifan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new 9fa18d2bd KUDU-3451 fix memory leak in scan_token-test
9fa18d2bd is described below

commit 9fa18d2bd53b4b54439b7967a3b6311c3f65fe81
Author: Marton Greber <gr...@gmail.com>
AuthorDate: Tue Feb 21 16:47:43 2023 +0100

    KUDU-3451 fix memory leak in scan_token-test
    
    This patch adds ElementDeleters to the test "TestScanTokensWithQueryId"
    to fix the scan token leaks.
    
    Running the test “TestScanTokensWithQueryId” 1024 times:
            - without this patch all of them failed,
            - with this patch, none of them failed, all were succesful.
    
    Change-Id: Ic9f47dc0842f415ab1725a8080d59595896dc57e
    Reviewed-on: http://gerrit.cloudera.org:8080/19526
    Reviewed-by: Attila Bukor <ab...@apache.org>
    Tested-by: Kudu Jenkins
    Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
    Reviewed-by: Yifan Zhang <ch...@163.com>
---
 src/kudu/client/scan_token-test.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/kudu/client/scan_token-test.cc b/src/kudu/client/scan_token-test.cc
index 21c3d9b16..165190fe7 100644
--- a/src/kudu/client/scan_token-test.cc
+++ b/src/kudu/client/scan_token-test.cc
@@ -719,6 +719,7 @@ TEST_F(ScanTokenTest, TestScanTokensWithQueryId) {
   // Scan with query id.
   {
     vector<KuduScanToken*> tokens;
+    ElementDeleter deleter(&tokens);
     KuduScanTokenBuilder builder(table.get());
     ASSERT_OK(builder.SetQueryId("query-id-for-test"));
     ASSERT_OK(builder.Build(&tokens));
@@ -744,6 +745,7 @@ TEST_F(ScanTokenTest, TestScanTokensWithQueryId) {
   // Scan without query id.
   {
     vector<KuduScanToken*> tokens;
+    ElementDeleter deleter(&tokens);
     KuduScanTokenBuilder builder(table.get());
     ASSERT_OK(builder.Build(&tokens));