[GitHub] [shiro-site] bdemers commented on a change in pull request #82: Variable interpolation section on configuration doc

[GitBox <gi...@apache.org>]

bdemers commented on a change in pull request #82:
URL: https://github.com/apache/shiro-site/pull/82#discussion_r634409994



##########
File path: configuration.md.vtl
##########
@@ -342,6 +343,26 @@ anObject.map = $objectKey1:$objectValue1, $objectKey2:$objectValue2
 ...
 ```
 
+<a name="Configuration-VariableInterpolation"></a>
+#[[######Variable Interpolation]]#
+
+You can use variable interpolation when defining values. Supported types are environment variables, system properties and constants.
+
+For constants, use `${const:CONSTANT_NAME}`, for environment variables and system properties, use `${ENV_VARIABLE_NAME}` or ${`PROPERTY`}.

Review comment:
       ```suggestion
   For constants, use `${const:com.example.YourClass.CONSTANT_NAME}`, for environment variables and system properties, use `${ENV_VARIABLE_NAME}` or `${system.property}`.
   ```
   
   Use fully qualified name for const example, and lower case for system properties, as that is _normally_ the convention
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org