[jira] Commented: (TRINIDAD-792) Making Reorder,Remove ChildComponentChange generic to all the attributes

["Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TRINIDAD-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539625 ] 

Scott O'Bryan commented on TRINIDAD-792:
----------------------------------------

Hey Shafi,  1.2.3-core has been release meaning we can't really change it.  Is this a change that is specific to the 1.2 branch or is this something that we should commit to trunk?

> Making Reorder,Remove ChildComponentChange generic to all the attributes
> ------------------------------------------------------------------------
>
>                 Key: TRINIDAD-792
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-792
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Components
>    Affects Versions: 1.2.3-core
>            Reporter: shafi khan
>            Assignee: Scott O'Bryan
>         Attachments: trunk.patch
>
>
> This is to avoid the requirement that " id attribute should always be specified for the children' in case of RemoveChildComponentChange, ReorderChildrenComponentChange. 
> This makes the user to always specify 'id' attribute explicitly on the children.  This leads to an increase of html output. Instead they can have custom attribute on the component.  The users will have to pass custom attribute's value and custom attribute's name to the RemoveChildComponentChange's constructor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.