You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2009/06/02 22:39:08 UTC
[jira] Created: (HADOOP-5961) DataNode should implement should use
ToolRunner
DataNode should implement should use ToolRunner
-----------------------------------------------
Key: HADOOP-5961
URL: https://issues.apache.org/jira/browse/HADOOP-5961
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Reporter: Raghu Angadi
Assignee: Raghu Angadi
DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
I will submit a patch and a shell script that works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5961) DataNode should understand generic
hadoop options
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5961:
---------------------------------
Status: Patch Available (was: Open)
This does not need unit tests.
> DataNode should understand generic hadoop options
> -------------------------------------------------
>
> Key: HADOOP-5961
> URL: https://issues.apache.org/jira/browse/HADOOP-5961
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Attachments: HADOOP-5961.patch, run-datanode.sh
>
>
> DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
> I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
> I will submit a patch and a shell script that works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5961) DataNode should understand generic
hadoop options
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715720#action_12715720 ]
Jakob Homan commented on HADOOP-5961:
-------------------------------------
+1 on the patch. Works as advertised. Is there any reason not to include the script and integrate it with the other shell scripts? The script works fine, but would need some validation (can only open 10 datanodes as it stands), header file, etc. This would make it easy for other developers to use without having to track down this JIRA months or years from now.
> DataNode should understand generic hadoop options
> -------------------------------------------------
>
> Key: HADOOP-5961
> URL: https://issues.apache.org/jira/browse/HADOOP-5961
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Attachments: HADOOP-5961.patch, run-datanode.sh
>
>
> DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
> I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
> I will submit a patch and a shell script that works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5961) DataNode should understand generic
hadoop options
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716483#action_12716483 ]
Hadoop QA commented on HADOOP-5961:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12409907/HADOOP-5961.patch
against trunk revision 781816.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/464/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/464/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/464/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/464/console
This message is automatically generated.
> DataNode should understand generic hadoop options
> -------------------------------------------------
>
> Key: HADOOP-5961
> URL: https://issues.apache.org/jira/browse/HADOOP-5961
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Attachments: HADOOP-5961.patch, HADOOP-5961.patch, run-datanode.sh, run-datanode.sh
>
>
> DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
> I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
> I will submit a patch and a shell script that works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5961) DataNode should understand generic
hadoop options
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5961:
---------------------------------
Tags: hdfs datanode
Resolution: Fixed
Fix Version/s: 0.2.1
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
> DataNode should understand generic hadoop options
> -------------------------------------------------
>
> Key: HADOOP-5961
> URL: https://issues.apache.org/jira/browse/HADOOP-5961
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Fix For: 0.2.1
>
> Attachments: HADOOP-5961.patch, HADOOP-5961.patch, run-datanode.sh, run-datanode.sh
>
>
> DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
> I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
> I will submit a patch and a shell script that works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5961) DataNode should understand generic
hadoop options
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5961:
---------------------------------
Description:
DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
I will submit a patch and a shell script that works.
was:
DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
I will submit a patch and a shell script that works.
Summary: DataNode should understand generic hadoop options (was: DataNode should implement should use ToolRunner)
> DataNode should understand generic hadoop options
> -------------------------------------------------
>
> Key: HADOOP-5961
> URL: https://issues.apache.org/jira/browse/HADOOP-5961
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
>
> DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
> I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
> I will submit a patch and a shell script that works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5961) DataNode should understand generic
hadoop options
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5961:
---------------------------------
Attachment: run-datanode.sh
run-datanode.sh : an example script to start multiple datanodes on one machine.
> DataNode should understand generic hadoop options
> -------------------------------------------------
>
> Key: HADOOP-5961
> URL: https://issues.apache.org/jira/browse/HADOOP-5961
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Attachments: run-datanode.sh
>
>
> DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
> I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
> I will submit a patch and a shell script that works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5961) DataNode should understand generic
hadoop options
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5961:
---------------------------------
Attachment: HADOOP-5961.patch
Reattach the patch so that Hudson picks up the right one.
> DataNode should understand generic hadoop options
> -------------------------------------------------
>
> Key: HADOOP-5961
> URL: https://issues.apache.org/jira/browse/HADOOP-5961
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Attachments: HADOOP-5961.patch, HADOOP-5961.patch, run-datanode.sh, run-datanode.sh
>
>
> DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
> I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
> I will submit a patch and a shell script that works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5961) DataNode should understand generic
hadoop options
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715733#action_12715733 ]
Raghu Angadi commented on HADOOP-5961:
--------------------------------------
Thanks Jakob.
The current script is extremely basic, but gets the job done. It is more like command line alias. Still I spend more time the script than the actual code change in DataNode. It would take some time to write a good script and for associated help and support. We could consider later that if there is more interest.
> DataNode should understand generic hadoop options
> -------------------------------------------------
>
> Key: HADOOP-5961
> URL: https://issues.apache.org/jira/browse/HADOOP-5961
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Attachments: HADOOP-5961.patch, run-datanode.sh
>
>
> DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
> I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
> I will submit a patch and a shell script that works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5961) DataNode should understand generic
hadoop options
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5961:
---------------------------------
Attachment: HADOOP-5961.patch
Patch attached. DataNode does not need to implement 'Tool'. It can just use {{GenericOptionsParser}} directly.
> DataNode should understand generic hadoop options
> -------------------------------------------------
>
> Key: HADOOP-5961
> URL: https://issues.apache.org/jira/browse/HADOOP-5961
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Attachments: HADOOP-5961.patch, run-datanode.sh
>
>
> DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
> I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
> I will submit a patch and a shell script that works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5961) DataNode should understand generic
hadoop options
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5961:
---------------------------------
Fix Version/s: (was: 0.2.1)
0.21.0
Fix 'Fix Version'. Thanks Koji.
> DataNode should understand generic hadoop options
> -------------------------------------------------
>
> Key: HADOOP-5961
> URL: https://issues.apache.org/jira/browse/HADOOP-5961
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5961.patch, HADOOP-5961.patch, run-datanode.sh, run-datanode.sh
>
>
> DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
> I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
> I will submit a patch and a shell script that works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5961) DataNode should understand generic
hadoop options
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5961:
---------------------------------
Attachment: run-datanode.sh
run-datanode.sh : Minor typo fixes
> DataNode should understand generic hadoop options
> -------------------------------------------------
>
> Key: HADOOP-5961
> URL: https://issues.apache.org/jira/browse/HADOOP-5961
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Attachments: HADOOP-5961.patch, HADOOP-5961.patch, run-datanode.sh, run-datanode.sh
>
>
> DataNode should use ToolRunner to parse generic hadoop options (like -Dconfig.var=value). Apart from being more consistent with rest of the hadoop programs, this is necessary to write a simple script to run multiple datanodes on the same node.
> I had proposed a simple shell script to running multiple datanodes on a the user mailing list http://www.nabble.com/Contributing-to-hadoop-td22198897.html, but it requires that DataNode parses -D option.
> I will submit a patch and a shell script that works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.