You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ivan Pavlukhin (Jira)" <ji...@apache.org> on 2020/02/10 18:17:00 UTC
[jira] [Comment Edited] (IGNITE-10698) Get rid of
@MXBeanParametersNames and @MXBeanParametersDescriptions
[ https://issues.apache.org/jira/browse/IGNITE-10698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033829#comment-17033829 ]
Ivan Pavlukhin edited comment on IGNITE-10698 at 2/10/20 6:16 PM:
------------------------------------------------------------------
[~agoncharuk], [~agura], as long we have a patch, I suppose we should set _fix version_ to 2.9.
was (Author: pavlukhin):
[~agoncharuk], [~agura], as long we have a patch, I suppose should set _fix version_ to 2.9.
> Get rid of @MXBeanParametersNames and @MXBeanParametersDescriptions
> -------------------------------------------------------------------
>
> Key: IGNITE-10698
> URL: https://issues.apache.org/jira/browse/IGNITE-10698
> Project: Ignite
> Issue Type: Task
> Reporter: Yakov Zhdanov
> Assignee: Lev Kiselev
> Priority: Major
> Labels: newbie, pull-request-available, usability
> Fix For: 3.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {noformat}
> @MXBeanDescription("Returns or kills transactions matching the filter conditions.")
> @MXBeanParametersNames(
> {
> "minDuration",
> "minSize",
> "prj",
> "consistentIds",
> "xid",
> "lbRegex",
> "limit",
> "order",
> "detailed",
> "kill"
> }
> )
> @MXBeanParametersDescriptions(
> {
> "Minimum duration (seconds).",
> "Minimum size.",
> "Projection (servers|clients).",
> "Consistent ids (separated by comma).",
> "Transaction XID.",
> "Label regexp.",
> "Limit a number of transactions collected on each node.",
> "Order by DURATION|SIZE.",
> "Show detailed description, otherwise only count.",
> "Kill matching transactions (be careful)."
> }
> )
> {noformat}
> Above looks pretty ugly and is very error prone due to messing names and descr order or number of strings.
> I would suggest to introduce individual parameters annotations and get them via mtd.getParamterAnnotations() at runtime.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)