You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Joe Bowser (JIRA)" <ji...@apache.org> on 2012/10/09 21:52:03 UTC
[jira] [Created] (CB-1611) Use browserHistory by default
Joe Bowser created CB-1611:
------------------------------
Summary: Use browserHistory by default
Key: CB-1611
URL: https://issues.apache.org/jira/browse/CB-1611
Project: Apache Cordova
Issue Type: Bug
Affects Versions: 2.1.0
Reporter: Joe Bowser
Fix For: 2.2.0
Instead of using navigator.app.backHistory(), we should use history.back. If we are using the WebView's history backHistory should still work, but use it and not the shim version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Reopened] (CB-1611) Use browserHistory by default
Posted by Andrew Grieve <ag...@chromium.org>.
I don't feel strongly (feel free to put the ifs back), the bug was that:
this.getProperty("useBrowserHistory", "false")
Should be:
this.getProperty("useBrowserHistory", "true")
On Tue, Oct 23, 2012 at 1:36 PM, Filip Maj <fi...@adobe.com> wrote:
> Agree, the code:
>
> !"false"
>
> is weird
>
> My $0.02.
>
> On 10/23/12 10:35 AM, "Joe Bowser (JIRA)" <ji...@apache.org> wrote:
>
> >
> > [
> >
> https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plug
> >in.system.issuetabpanels:all-tabpanel ]
> >
> >Joe Bowser reopened CB-1611:
> >----------------------------
> >
> >
> >I personally don't think that this is as readable as the previous version
> >which DID work but but did miss the deprecation. The current code is
> >unclear beacuse we're negating a string comparison for some reason, and
> >the string itself happens to be false.
> >
> >I honestly think we should revert this back. This was working and this
> >is really just a style issue.
> >
> >> Use browserHistory by default
> >> -----------------------------
> >>
> >> Key: CB-1611
> >> URL: https://issues.apache.org/jira/browse/CB-1611
> >> Project: Apache Cordova
> >> Issue Type: Bug
> >> Components: Android
> >> Affects Versions: 2.1.0
> >> Reporter: Joe Bowser
> >> Assignee: Andrew Grieve
> >> Fix For: 2.2.0
> >>
> >>
> >> Instead of using navigator.app.backHistory(), we should use
> >>history.back. If we are using the WebView's history backHistory should
> >>still work, but use it and not the shim version.
> >
> >--
> >This message is automatically generated by JIRA.
> >If you think it was sent incorrectly, please contact your JIRA
> >administrators
> >For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
Re: [jira] [Reopened] (CB-1611) Use browserHistory by default
Posted by Filip Maj <fi...@adobe.com>.
Agree, the code:
!"false"
is weird
My $0.02.
On 10/23/12 10:35 AM, "Joe Bowser (JIRA)" <ji...@apache.org> wrote:
>
> [
>https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plug
>in.system.issuetabpanels:all-tabpanel ]
>
>Joe Bowser reopened CB-1611:
>----------------------------
>
>
>I personally don't think that this is as readable as the previous version
>which DID work but but did miss the deprecation. The current code is
>unclear beacuse we're negating a string comparison for some reason, and
>the string itself happens to be false.
>
>I honestly think we should revert this back. This was working and this
>is really just a style issue.
>
>> Use browserHistory by default
>> -----------------------------
>>
>> Key: CB-1611
>> URL: https://issues.apache.org/jira/browse/CB-1611
>> Project: Apache Cordova
>> Issue Type: Bug
>> Components: Android
>> Affects Versions: 2.1.0
>> Reporter: Joe Bowser
>> Assignee: Andrew Grieve
>> Fix For: 2.2.0
>>
>>
>> Instead of using navigator.app.backHistory(), we should use
>>history.back. If we are using the WebView's history backHistory should
>>still work, but use it and not the shim version.
>
>--
>This message is automatically generated by JIRA.
>If you think it was sent incorrectly, please contact your JIRA
>administrators
>For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CB-1611) Use browserHistory by default
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser reopened CB-1611:
----------------------------
I personally don't think that this is as readable as the previous version which DID work but but did miss the deprecation. The current code is unclear beacuse we're negating a string comparison for some reason, and the string itself happens to be false.
I honestly think we should revert this back. This was working and this is really just a style issue.
> Use browserHistory by default
> -----------------------------
>
> Key: CB-1611
> URL: https://issues.apache.org/jira/browse/CB-1611
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 2.1.0
> Reporter: Joe Bowser
> Assignee: Andrew Grieve
> Fix For: 2.2.0
>
>
> Instead of using navigator.app.backHistory(), we should use history.back. If we are using the WebView's history backHistory should still work, but use it and not the shim version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1611) Use browserHistory by default
Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482530#comment-13482530 ]
Andrew Grieve commented on CB-1611:
-----------------------------------
Hate to be nitpicky, but I've tweaked the deprecation comment again so that it references the 2.2.0 release (or else it's not clear when "in six months" is)
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=7d3afcab94f130a346da705576c8daf7a91f089f
> Use browserHistory by default
> -----------------------------
>
> Key: CB-1611
> URL: https://issues.apache.org/jira/browse/CB-1611
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 2.1.0
> Reporter: Joe Bowser
> Assignee: Joe Bowser
> Fix For: 2.2.0
>
>
> Instead of using navigator.app.backHistory(), we should use history.back. If we are using the WebView's history backHistory should still work, but use it and not the shim version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-1611) Use browserHistory by default
Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Grieve resolved CB-1611.
-------------------------------
Resolution: Fixed
First commit didn't actually change the default. New commit changes default and adds a deprecation log message.
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=6a1e089b73c90becfd131417424aa3076e51d368
> Use browserHistory by default
> -----------------------------
>
> Key: CB-1611
> URL: https://issues.apache.org/jira/browse/CB-1611
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 2.1.0
> Reporter: Joe Bowser
> Assignee: Andrew Grieve
> Fix For: 2.2.0
>
>
> Instead of using navigator.app.backHistory(), we should use history.back. If we are using the WebView's history backHistory should still work, but use it and not the shim version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-1611) Use browserHistory by default
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser resolved CB-1611.
----------------------------
Resolution: Fixed
> Use browserHistory by default
> -----------------------------
>
> Key: CB-1611
> URL: https://issues.apache.org/jira/browse/CB-1611
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 2.1.0
> Reporter: Joe Bowser
> Fix For: 2.2.0
>
>
> Instead of using navigator.app.backHistory(), we should use history.back. If we are using the WebView's history backHistory should still work, but use it and not the shim version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1611) Use browserHistory by default
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480024#comment-13480024 ]
Joe Bowser commented on CB-1611:
--------------------------------
Here's the commit from the log: https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=0d409f0fe3f09467fc2d88fce1cf97e4acc54a0b
I didn't add a deprecation message, instead I made sure that navigator.app.backHistory() still works. I'm not sure a deprecation warning is still here, because we haven't actually deprecated a part of the API yet and this will just be spammy. We should just note this in the release notes.
> Use browserHistory by default
> -----------------------------
>
> Key: CB-1611
> URL: https://issues.apache.org/jira/browse/CB-1611
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 2.1.0
> Reporter: Joe Bowser
> Fix For: 2.2.0
>
>
> Instead of using navigator.app.backHistory(), we should use history.back. If we are using the WebView's history backHistory should still work, but use it and not the shim version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-1611) Use browserHistory by default
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser resolved CB-1611.
----------------------------
Resolution: Fixed
Assignee: Joe Bowser (was: Andrew Grieve)
> Use browserHistory by default
> -----------------------------
>
> Key: CB-1611
> URL: https://issues.apache.org/jira/browse/CB-1611
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 2.1.0
> Reporter: Joe Bowser
> Assignee: Joe Bowser
> Fix For: 2.2.0
>
>
> Instead of using navigator.app.backHistory(), we should use history.back. If we are using the WebView's history backHistory should still work, but use it and not the shim version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-1611) Use browserHistory by default
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser updated CB-1611:
---------------------------
Component/s: Android
> Use browserHistory by default
> -----------------------------
>
> Key: CB-1611
> URL: https://issues.apache.org/jira/browse/CB-1611
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 2.1.0
> Reporter: Joe Bowser
> Fix For: 2.2.0
>
>
> Instead of using navigator.app.backHistory(), we should use history.back. If we are using the WebView's history backHistory should still work, but use it and not the shim version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CB-1611) Use browserHistory by default
Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Grieve reopened CB-1611:
-------------------------------
Assignee: Andrew Grieve
> Use browserHistory by default
> -----------------------------
>
> Key: CB-1611
> URL: https://issues.apache.org/jira/browse/CB-1611
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 2.1.0
> Reporter: Joe Bowser
> Assignee: Andrew Grieve
> Fix For: 2.2.0
>
>
> Instead of using navigator.app.backHistory(), we should use history.back. If we are using the WebView's history backHistory should still work, but use it and not the shim version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1611) Use browserHistory by default
Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479972#comment-13479972 ]
Andrew Grieve commented on CB-1611:
-----------------------------------
Joe, what's the commit link for this? Did you add a deprecation message for the non-browser-history case?
> Use browserHistory by default
> -----------------------------
>
> Key: CB-1611
> URL: https://issues.apache.org/jira/browse/CB-1611
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 2.1.0
> Reporter: Joe Bowser
> Fix For: 2.2.0
>
>
> Instead of using navigator.app.backHistory(), we should use history.back. If we are using the WebView's history backHistory should still work, but use it and not the shim version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1611) Use browserHistory by default
Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480044#comment-13480044 ]
Andrew Grieve commented on CB-1611:
-----------------------------------
How about a log warning on start-up if they have USE_BROWSER_HISTORY==NO? I think this is what was causing Braden to pull his hair out yesterday because his app had no warnings or errors, but showed just a blank screen.
> Use browserHistory by default
> -----------------------------
>
> Key: CB-1611
> URL: https://issues.apache.org/jira/browse/CB-1611
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 2.1.0
> Reporter: Joe Bowser
> Fix For: 2.2.0
>
>
> Instead of using navigator.app.backHistory(), we should use history.back. If we are using the WebView's history backHistory should still work, but use it and not the shim version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1611) Use browserHistory by default
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482512#comment-13482512 ]
Joe Bowser commented on CB-1611:
--------------------------------
Changed the code that checks the string for readability, and clarified what's going on here. If you disable the history you can't use history.back().
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=5f1cda07e707b39cff1c06e7635d25a11b502eb1
> Use browserHistory by default
> -----------------------------
>
> Key: CB-1611
> URL: https://issues.apache.org/jira/browse/CB-1611
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 2.1.0
> Reporter: Joe Bowser
> Assignee: Andrew Grieve
> Fix For: 2.2.0
>
>
> Instead of using navigator.app.backHistory(), we should use history.back. If we are using the WebView's history backHistory should still work, but use it and not the shim version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira