You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by andreaturli <gi...@git.apache.org> on 2016/10/26 10:36:32 UTC

[GitHub] brooklyn-server pull request #394: add exist check before getting the blob

GitHub user andreaturli opened a pull request:

    https://github.com/apache/brooklyn-server/pull/394

    add exist check before getting the blob

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andreaturli/brooklyn-server fix/JcloudsStoreObjectAccessor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/394.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #394
    
----
commit 6f6f370309ed1bbd479d193cdc34f8afc25589ee
Author: Andrea Turli <an...@gmail.com>
Date:   2016-10-26T10:31:38Z

    add exist check before getting the blob

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #394: add exist check before getting the blob

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/394


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #394: add exist check before getting the blob

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/394
  
    from andrea:
    
    | Blob blob = blobStore.getBlob(containerName, blobName); is retryable while blobExists is not. When you disable wire logging, jclouds uses a different code path which ends up in a IOException rather than KeyNotFoundException causing problems in Brooklyn persistence
    
    | as jclouds convert KeyNotFoundException into null, and propagates IOException for that getBlob method
    
    looks reasonable to me, merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---