You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Kay Kay (JIRA)" <ji...@apache.org> on 2010/02/10 03:00:27 UTC
[jira] Created: (HBASE-2209) Support of List [ ] in
HBaseOutputWritable for serialization
Support of List [ ] in HBaseOutputWritable for serialization
-------------------------------------------------------------
Key: HBASE-2209
URL: https://issues.apache.org/jira/browse/HBASE-2209
Project: Hadoop HBase
Issue Type: Improvement
Reporter: Kay Kay
Attachments: HBASE-2209.patch
On a higher language semantics , List < > are very useful for manipulation and when finally sent down to the wire - the protocol currently seems to take only [ ] through an expensive copy.
Supporting List <T > directly would save us the copy in terms of memory and add to faster / deserialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2209) Support of List [ ] in
HBaseOutputWritable for serialization
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832269#action_12832269 ]
Kay Kay commented on HBASE-2209:
--------------------------------
This is kind of cheating in the sense, while deserializing - all List<T> always comes down an ArrayList<T> .
As mentioned offline in the IRC by dj_ryan , avro as a generic solution for RPC would address a lot of this. But until that happens - here is the patch.
> Support of List [ ] in HBaseOutputWritable for serialization
> -------------------------------------------------------------
>
> Key: HBASE-2209
> URL: https://issues.apache.org/jira/browse/HBASE-2209
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-2209.patch, HBASE-2209.patch
>
>
> On a higher language semantics , List < > are very useful for manipulation and when finally sent down to the wire - the protocol currently seems to take only [ ] through an expensive copy.
> Supporting List <T > directly would save us the copy in terms of memory and add to faster / deserialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2209) Support of List [ ] in
HBaseOutputWritable for serialization
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HBASE-2209:
---------------------------
Attachment: HBASE-2209.patch
v2.0
-----
RPC protocol version changed to 22.
Added test case for List.class / and a subtype (ArrayList.class). Better type inference. due to the Class.isAssignableFrom(clazz); , as compared to equality that makes no sense.
> Support of List [ ] in HBaseOutputWritable for serialization
> -------------------------------------------------------------
>
> Key: HBASE-2209
> URL: https://issues.apache.org/jira/browse/HBASE-2209
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-2209.patch, HBASE-2209.patch
>
>
> On a higher language semantics , List < > are very useful for manipulation and when finally sent down to the wire - the protocol currently seems to take only [ ] through an expensive copy.
> Supporting List <T > directly would save us the copy in terms of memory and add to faster / deserialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2209) Support of List [ ] in
HBaseOutputWritable for serialization
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-2209:
-------------------------
Resolution: Fixed
Assignee: Kay Kay
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to TRUNK. Thanks for the patch Kay Kay.
> Support of List [ ] in HBaseOutputWritable for serialization
> -------------------------------------------------------------
>
> Key: HBASE-2209
> URL: https://issues.apache.org/jira/browse/HBASE-2209
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-2209.patch, HBASE-2209.patch
>
>
> On a higher language semantics , List < > are very useful for manipulation and when finally sent down to the wire - the protocol currently seems to take only [ ] through an expensive copy.
> Supporting List <T > directly would save us the copy in terms of memory and add to faster / deserialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2209) Support of List [ ] in
HBaseOutputWritable for serialization
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HBASE-2209:
---------------------------
Attachment: HBASE-2209.patch
List serialization / deserialization added.
Type erasure gets in the way of smooth type safety on either ends of the wire, but that is no reason to convert a List<T> to a T [ ] before sending down the wire.
> Support of List [ ] in HBaseOutputWritable for serialization
> -------------------------------------------------------------
>
> Key: HBASE-2209
> URL: https://issues.apache.org/jira/browse/HBASE-2209
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Kay Kay
> Attachments: HBASE-2209.patch
>
>
> On a higher language semantics , List < > are very useful for manipulation and when finally sent down to the wire - the protocol currently seems to take only [ ] through an expensive copy.
> Supporting List <T > directly would save us the copy in terms of memory and add to faster / deserialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2209) Support of List [ ] in
HBaseOutputWritable for serialization
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832109#action_12832109 ]
Kay Kay commented on HBASE-2209:
--------------------------------
Being an RPC change, more eyeballs can help. Suggestions / criticisms welcome. rationale for incorporating List<T> given at the top.
> Support of List [ ] in HBaseOutputWritable for serialization
> -------------------------------------------------------------
>
> Key: HBASE-2209
> URL: https://issues.apache.org/jira/browse/HBASE-2209
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-2209.patch, HBASE-2209.patch
>
>
> On a higher language semantics , List < > are very useful for manipulation and when finally sent down to the wire - the protocol currently seems to take only [ ] through an expensive copy.
> Supporting List <T > directly would save us the copy in terms of memory and add to faster / deserialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2209) Support of List [ ] in
HBaseOutputWritable for serialization
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831860#action_12831860 ]
Kay Kay commented on HBASE-2209:
--------------------------------
declaredClass == List.class does not make sense. it should rely on Class.isSubClass / similar type inference model.
> Support of List [ ] in HBaseOutputWritable for serialization
> -------------------------------------------------------------
>
> Key: HBASE-2209
> URL: https://issues.apache.org/jira/browse/HBASE-2209
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-2209.patch
>
>
> On a higher language semantics , List < > are very useful for manipulation and when finally sent down to the wire - the protocol currently seems to take only [ ] through an expensive copy.
> Supporting List <T > directly would save us the copy in terms of memory and add to faster / deserialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2209) Support of List [ ] in
HBaseOutputWritable for serialization
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832267#action_12832267 ]
Jean-Daniel Cryans commented on HBASE-2209:
-------------------------------------------
+1
> Support of List [ ] in HBaseOutputWritable for serialization
> -------------------------------------------------------------
>
> Key: HBASE-2209
> URL: https://issues.apache.org/jira/browse/HBASE-2209
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-2209.patch, HBASE-2209.patch
>
>
> On a higher language semantics , List < > are very useful for manipulation and when finally sent down to the wire - the protocol currently seems to take only [ ] through an expensive copy.
> Supporting List <T > directly would save us the copy in terms of memory and add to faster / deserialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2209) Support of List [ ] in
HBaseOutputWritable for serialization
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HBASE-2209:
---------------------------
Fix Version/s: 0.21.0
Targeted for 0.21.0 only ( *not backward compatible* , due to RPC change of incorporating lists as well ).
> Support of List [ ] in HBaseOutputWritable for serialization
> -------------------------------------------------------------
>
> Key: HBASE-2209
> URL: https://issues.apache.org/jira/browse/HBASE-2209
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-2209.patch
>
>
> On a higher language semantics , List < > are very useful for manipulation and when finally sent down to the wire - the protocol currently seems to take only [ ] through an expensive copy.
> Supporting List <T > directly would save us the copy in terms of memory and add to faster / deserialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2209) Support of List [ ] in
HBaseOutputWritable for serialization
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HBASE-2209:
---------------------------
Status: Patch Available (was: Open)
1. Added tests
2. Incremented RPC version.
3. List< T > accepted by the protocol as well.
> Support of List [ ] in HBaseOutputWritable for serialization
> -------------------------------------------------------------
>
> Key: HBASE-2209
> URL: https://issues.apache.org/jira/browse/HBASE-2209
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-2209.patch, HBASE-2209.patch
>
>
> On a higher language semantics , List < > are very useful for manipulation and when finally sent down to the wire - the protocol currently seems to take only [ ] through an expensive copy.
> Supporting List <T > directly would save us the copy in terms of memory and add to faster / deserialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.