You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/05/05 23:17:02 UTC
[kudu-CR] [docs] simplify multi-master migration instructions
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18500
Change subject: [docs] simplify multi-master migration instructions
......................................................................
[docs] simplify multi-master migration instructions
This patch updates the instructions for the multi-master migration
procedure by removing an extra conditional step based on the choice
whether DNS aliases were configured or not.
Change-Id: Ie9c530c194b40d658c7764dd553c5b16806dca90
---
M docs/administration.adoc
1 file changed, 17 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/18500/1
--
To view, visit http://gerrit.cloudera.org:8080/18500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9c530c194b40d658c7764dd553c5b16806dca90
Gerrit-Change-Number: 18500
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [docs] simplify multi-master migration instructions
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18500 )
Change subject: [docs] simplify multi-master migration instructions
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9c530c194b40d658c7764dd553c5b16806dca90
Gerrit-Change-Number: 18500
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 May 2022 15:25:28 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] simplify multi-master migration instructions
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18500 )
Change subject: [docs] simplify multi-master migration instructions
......................................................................
Patch Set 3: Code-Review+1
Sorry missed this but looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/18500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9c530c194b40d658c7764dd553c5b16806dca90
Gerrit-Change-Number: 18500
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 May 2022 19:55:11 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] simplify multi-master migration instructions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18500 )
Change subject: [docs] simplify multi-master migration instructions
......................................................................
[docs] simplify multi-master migration instructions
This patch updates the instructions for the multi-master migration
procedure by removing an extra conditional step based on the choice
whether DNS aliases were configured or not.
Change-Id: Ie9c530c194b40d658c7764dd553c5b16806dca90
Reviewed-on: http://gerrit.cloudera.org:8080/18500
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M docs/administration.adoc
1 file changed, 30 insertions(+), 33 deletions(-)
Approvals:
Kudu Jenkins: Verified
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9c530c194b40d658c7764dd553c5b16806dca90
Gerrit-Change-Number: 18500
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] simplify multi-master migration instructions
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Khazar Mammadli has posted comments on this change. ( http://gerrit.cloudera.org:8080/18500 )
Change subject: [docs] simplify multi-master migration instructions
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9c530c194b40d658c7764dd553c5b16806dca90
Gerrit-Change-Number: 18500
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 May 2022 11:37:29 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] simplify multi-master migration instructions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18500 )
Change subject: [docs] simplify multi-master migration instructions
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18500/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/18500/1/docs/administration.adoc@637
PS1, Line 637: ('kudu.master_addresses' = 'master-1.example.com,master-2.example.com');
> Should we use 3 masters in these examples to align with the requirement of
It's a very good point. Done.
--
To view, visit http://gerrit.cloudera.org:8080/18500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9c530c194b40d658c7764dd553c5b16806dca90
Gerrit-Change-Number: 18500
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 May 2022 18:25:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] simplify multi-master migration instructions
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18500 )
Change subject: [docs] simplify multi-master migration instructions
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18500/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/18500/1/docs/administration.adoc@637
PS1, Line 637: ('kudu.master_addresses' = 'master-1.example.com,master-2.example.com');
Should we use 3 masters in these examples to align with the requirement of having an odd number of masters?
--
To view, visit http://gerrit.cloudera.org:8080/18500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9c530c194b40d658c7764dd553c5b16806dca90
Gerrit-Change-Number: 18500
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 May 2022 11:48:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] simplify multi-master migration instructions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Abhishek Chennaka, Khazar Mammadli,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18500
to look at the new patch set (#2).
Change subject: [docs] simplify multi-master migration instructions
......................................................................
[docs] simplify multi-master migration instructions
This patch updates the instructions for the multi-master migration
procedure by removing an extra conditional step based on the choice
whether DNS aliases were configured or not.
Change-Id: Ie9c530c194b40d658c7764dd553c5b16806dca90
---
M docs/administration.adoc
1 file changed, 30 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/18500/2
--
To view, visit http://gerrit.cloudera.org:8080/18500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie9c530c194b40d658c7764dd553c5b16806dca90
Gerrit-Change-Number: 18500
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)