You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/12/21 13:54:22 UTC

[GitHub] [accumulo] EdColeman commented on a change in pull request #2396: Add metric for number of open files for scans

EdColeman commented on a change in pull request #2396:
URL: https://github.com/apache/accumulo/pull/2396#discussion_r773154732



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/metrics/TabletServerScanMetrics.java
##########
@@ -44,8 +49,19 @@ public void addYield(long value) {
     yields.record(value);
   }
 
+  public void incrementOpenFiles(int delta) {
+    Preconditions.checkArgument(delta >= 0, "Parameter must be zero or positive");

Review comment:
       Do we need to throw an unchecked exception here?  Would Math.max(0, val) work instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org