[GitHub] [incubator-superset] betodealmeida opened a new pull request #7240: Fix for tagging backend

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #7240: Fix for tagging backend
URL: https://github.com/apache/incubator-superset/pull/7240
 
 
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
     http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   ##### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   This PR has bug fixes for the tagging backend, and a few improvements on the SQLAlchemy queries used by it.
   
   The tags model has a clowny bug 🤡where the type of tags was being set incorrectly in the parent class (see `superset/models/tags.py` below). This should fix all the weird problems that were happening with tags (new charts starting with tags, and wrong objects showing up in the tag search).
   
   For the SQLAlchemy queries, I rewrote them to use explicit joins (to avoid accidents with cross joins), and also made the logic more clear.
   
   <!-- ##### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF -->
   <!--- Skip this if not applicable -->
   
   ##### TEST PLAN
   <!--- What steps were taken to verify -->
   
   I created charts and dashboards, tagged them, and verified that everything is working as expected.
   
   ##### ADDITIONAL INFORMATION
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> 
   <!--- Check any relevant boxes with "x" -->
       [ ] Has associated issue:
       [ ] Changes UI
       [ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
       [ ] Introduces new feature or API
       [ ] Removes existing feature or API
       [x] Fixes bug
       [x] Refactors code
       [ ] Adds test(s)
   
   ##### REVIEWERS
   
   @xtinec (this might cause merge conflicts with our private cherry, LMK if you need help fixing it)
   @khtruong 
   @datability-io 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org