You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/06/08 22:44:30 UTC
Re: Review Request 35207: Included doxygen documentation in
docs/home.md.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35207/
-----------------------------------------------------------
(Updated June 8, 2015, 8:44 p.m.)
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Bugs: Mesos-2500
https://issues.apache.org/jira/browse/Mesos-2500
Repository: mesos
Description
-------
Included doxygen documentation in docs/home.md.
Diffs
-----
docs/home.md f2d3e32ca8a1b2735849242daaaf1a6201ce2684
Diff: https://reviews.apache.org/r/35207/diff/
Testing
-------
Thanks,
Joerg Schad
Re: Review Request 35207: Included doxygen documentation in
docs/home.md.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35207/#review87089
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35207]
All tests passed.
- Mesos ReviewBot
On June 8, 2015, 8:44 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35207/
> -----------------------------------------------------------
>
> (Updated June 8, 2015, 8:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Bugs: Mesos-2500
> https://issues.apache.org/jira/browse/Mesos-2500
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included doxygen documentation in docs/home.md.
>
>
> Diffs
> -----
>
> docs/home.md f2d3e32ca8a1b2735849242daaaf1a6201ce2684
>
> Diff: https://reviews.apache.org/r/35207/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 35207: Included doxygen documentation in
docs/home.md.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35207/#review87131
-----------------------------------------------------------
This will conflict with https://reviews.apache.org/r/35037/ (same intent), I personally prefere to have the seperate section API Documentation (and we need to add the Doxygen styleguide anyhow). Any preference?
- Joerg Schad
On June 8, 2015, 8:44 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35207/
> -----------------------------------------------------------
>
> (Updated June 8, 2015, 8:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Bugs: Mesos-2500
> https://issues.apache.org/jira/browse/Mesos-2500
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included doxygen documentation in docs/home.md.
>
>
> Diffs
> -----
>
> docs/home.md f2d3e32ca8a1b2735849242daaaf1a6201ce2684
>
> Diff: https://reviews.apache.org/r/35207/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 35207: Included doxygen documentation in
docs/home.md.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35207/#review87154
-----------------------------------------------------------
Ship it!
docs/home.md
<https://reviews.apache.org/r/35207/#comment139468>
This looks like it's the same thing that Niklas added in https://reviews.apache.org/r/35037? And this link doesn't work, 'documentation' is spelled wrong. I'm just going to kill this part for now since we're already linking to this from what Niklas added.
- Benjamin Hindman
On June 8, 2015, 8:44 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35207/
> -----------------------------------------------------------
>
> (Updated June 8, 2015, 8:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Bugs: Mesos-2500
> https://issues.apache.org/jira/browse/Mesos-2500
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included doxygen documentation in docs/home.md.
>
>
> Diffs
> -----
>
> docs/home.md f2d3e32ca8a1b2735849242daaaf1a6201ce2684
>
> Diff: https://reviews.apache.org/r/35207/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joerg Schad
>
>