You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2016/08/02 06:03:34 UTC

[GitHub] incubator-quickstep pull request #74: Removed the redundant query id in the ...

GitHub user zuyu opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/74

    Removed the redundant query id in the optimizer.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-quickstep optimizer-q-id

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #74
    
----
commit f565f33a479b6c815a68874beb1d0eaa66e807a1
Author: Zuyu Zhang <zu...@twitter.com>
Date:   2016-08-02T06:02:37Z

    Removed the redundant query id in the optimizer.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #74: Removed the redundant query id in the optimiz...

Posted by jianqiao <gi...@git.apache.org>.

Github user jianqiao commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/74
  
    This change looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #74: Removed the redundant query id in the optimiz...

Posted by zuyu <gi...@git.apache.org>.

Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/74
  
    `query_id` stores in `QueryHandle`, so `optimizer_context` does not need it.
    
    And there will be some follow-up changes to `QueryHandle` to capture the `client_id` which submits the query.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #74: Removed the redundant query id in the ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quickstep/pull/74


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #74: Removed the redundant query id in the optimiz...

Posted by pateljm <gi...@git.apache.org>.

Github user pateljm commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/74
  
    @jianqiao @hbdeshmukh Did any of you want the query_id for use in the future? 
    
    @zuyu: Can you expand on the reason to drop the query_id further? 
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---