[GitHub] [flink] zhuzhurk commented on a change in pull request #9637: [FLINK-13884] Set default delay for restart strategies to 1s

[GitBox <gi...@apache.org>]

zhuzhurk commented on a change in pull request #9637: [FLINK-13884] Set default delay for restart strategies to 1s
URL: https://github.com/apache/flink/pull/9637#discussion_r321957850
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java
 ##########
 @@ -116,10 +115,9 @@
 			Description.builder()
 				.text(
 					"Time interval for measuring failure rate if %s has been set to %s. " +
-						"It can be specified using Scala's %s notation: \"1 min\", \"20 s\"",
+						"It can be specified using the notation: \"1 min\", \"20 s\", \"100 ms\"",
 
 Review comment:
   With this change fewer time units are supported. 
   Previously supported time units are 
   {
       DAYS         -> "d day",
       HOURS        -> "h hour",
       MINUTES      -> "min minute",
       SECONDS      -> "s sec second",
       MILLISECONDS -> "ms milli millisecond",
       MICROSECONDS -> "µs micro microsecond",
       NANOSECONDS  -> "ns nano nanosecond"
    }
   Current TimeUtils only supports "h", "min", "s" and "ms".
   
   To avoid break existing job, we may need to support those time units supported by scala FiniteDuration.
   And maybe we also need a doc to specify supported time units and link this description to it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services