You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by michellephung <gi...@git.apache.org> on 2015/04/15 23:08:44 UTC
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
GitHub user michellephung opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/386
add loading lines to active tasks
I've added loading lines to active tasks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michellephung/couchdb-fauxton active-tasks-loading-lines
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/386.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #386
----
commit 2d4b78f6292ae0a86a066df0344f8cc58fd82446
Author: michellephung@gmail.com <mi...@gmail.com>
Date: 2015-04-15T21:08:07Z
add loading lines to active tasks
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-103231981
I did some UI changes (per request)
Still to-do:
- hook up copy button
- figure out how to change the x,y-position on the source sequence tray (where does the translate y: 0 come from?)
- write tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-100534913
@sebastianrothbucher
:) i can work on the the logic/naming a little more.
I'm still a little unhappy with the way the timing works, since the extra time is a little misleading for shorter time intervals, but I wanted to make it look like a smooth animation, and the trade off there is that there is this buffer of time. I like your suggestions, and I'm still working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by seanbarclay <gi...@git.apache.org>.
Github user seanbarclay commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-95340501
Quick UI idea: Here's two sketches that show how to reduce space in the status column by simply tucking the SEQ in a popover (like the API URL). This would allow you to view it and copy it if need be w/ a UI button.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#discussion_r29995481
--- Diff: app/addons/activetasks/actions.js ---
@@ -14,13 +14,14 @@ define([
'addons/activetasks/actiontypes',
'addons/activetasks/resources'
],
-function (FauxtonAPI, ActionTypes, Resources) {
+function (FauxtonAPI, ActionTypes, Resources, Actions) {
--- End diff --
good point!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-93584180
I added some loading lines, so that when we start to fetch, it shows the lines, then when the fetch is done, we turn off the lines.
However, I have added a 500 ms delay to turning off the lines, so that each time we are fetching, the user can see that something is happening at that time.
I also muted the color since the movement all the time can be distracting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by sebastianrothbucher <gi...@git.apache.org>.
Github user sebastianrothbucher commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#discussion_r29994895
--- Diff: app/addons/activetasks/stores.js ---
@@ -28,6 +28,35 @@ define([
this._pollingIntervalSeconds = 5;
this.sortCollectionByColumnHeader(this._sortByHeader);
this._backboneCollection = backboneCollection;
+ this.setIsLoading(true);
+ },
+
+ isLoading: function () {
+ return this._isLoading;
+ },
+
+ setIsLoading: function (bool) {
+ this._isLoading = bool;
+ if (bool) {
+ this.startTimerForLoading();
+ } else {
+ this.stopTimerForLoading();
+ }
+ },
+
+ startTimerForLoading: function () {
+ this._clockForLoadingLines = 0;
+ this._clockForLoadingLinesID = setInterval(function () {
+ this._clockForLoadingLines++;
--- End diff --
maybe this is silly, but: can we not just remember the time we started and compare it with the time of stop 2 determine whether or not we want to show the lines a little longer? (i.e. this._startTimeOfLoad=(new Date()).getTime() and if(((new Date()).getTime()-this._startTimeOfLoad)<x) then...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by sebastianrothbucher <gi...@git.apache.org>.
Github user sebastianrothbucher commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-94062235
I do like the idea (and the code - exept for tests as Robert pointed out already)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by sebastianrothbucher <gi...@git.apache.org>.
Github user sebastianrothbucher commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#discussion_r29994809
--- Diff: app/addons/activetasks/actions.js ---
@@ -14,13 +14,14 @@ define([
'addons/activetasks/actiontypes',
'addons/activetasks/resources'
],
-function (FauxtonAPI, ActionTypes, Resources) {
+function (FauxtonAPI, ActionTypes, Resources, Actions) {
return {
fetchAndSetActiveTasks: function (options) {
--- End diff --
isn't this thing the "real" init function?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-102504099
still working on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30864085
--- Diff: app/addons/activetasks/components.react.jsx ---
@@ -453,17 +384,75 @@ define([
<td>{startedOnMsg}</td>
<td>{updatedOnMsg}</td>
<td>{rowData.pid}</td>
- <td>{progressMsg}</td>
+ <td>{progressMsg}<ActiveTasksViewSourceSequence item={this.props.item}/></td>
</tr>
);
}
});
+ var ActiveTasksViewSourceSequence = React.createClass({
+ onTrayToggle: function (e) {
+ e.preventDefault();
+ this.refs.view_source_sequence_btn.toggle(function (shown) {
+ if (shown) {
+ this.refs.view_source_sequence_btn.getDOMNode().focus();
+ }
+ }.bind(this));
+ },
+
+ sequences: function (item) {
+ if (_.isNumber(item) || _.isString(item)) {
+ return (
+ <ComponentsReact.ClipboardWithTextField textToCopy={item} uniqueKey={item}>
+ </ComponentsReact.ClipboardWithTextField>
+ );
+ } else if (_.isArray(item)) {
+ return (
+ _.map(item, function (seq, i) {
+ return (
+ <ComponentsReact.ClipboardWithTextField textToCopy={seq} uniqueKey={i + Math.random(100)} key={i}>
+ </ComponentsReact.ClipboardWithTextField>
+ );
+ })
+ );
+ } else {
+ return (
+ <ComponentsReact.ClipboardWithTextField textToCopy="???" uniqueKey={item}>
+ </ComponentsReact.ClipboardWithTextField>
+ );
+ }
+ },
+
--- End diff --
I changed this, but some back story: I was surprised that the source_seq could return an array at all, I believe the first number in the array (if an array is returned) is the number of documents it has replicated, and the second number is the sequence number. ( Originally it was concatenated together! )
I'm not sure what I should do here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30854437
--- Diff: app/addons/activetasks/components.react.jsx ---
@@ -349,7 +280,7 @@ define([
onChange={this.onTableHeaderClick}>
<th className={th_class} value={this.props.headerName}>
<label
- className="header-field label-text"
+ className="header-field label-text active-tasks-header "
--- End diff --
superfluous space at the end
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-99193360
ok i need a little time to implement
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30854469
--- Diff: app/addons/activetasks/components.react.jsx ---
@@ -453,17 +384,71 @@ define([
<td>{startedOnMsg}</td>
<td>{updatedOnMsg}</td>
<td>{rowData.pid}</td>
- <td>{progressMsg}</td>
+ <td>{progressMsg}<ActiveTasksViewSourceSequence item={this.props.item}/></td>
</tr>
);
}
});
+ var ActiveTasksViewSourceSequence = React.createClass({
+ onTrayToggle: function (e) {
+ e.preventDefault();
+ this.refs.view_source_sequence_btn.toggle(function (shown) {
+ if (shown) {
+ this.refs.view_source_sequence_btn.getDOMNode().focus();
+ }
+ }.bind(this));
+ },
+
+ sequences: function (item) {
+ if (_.isNumber(item) ) {
+ return (
+ <ComponentsReact.ClipboardWithTextField textToCopy={item} uniqueKey={item}>
+ </ComponentsReact.ClipboardWithTextField>
+ );
--- End diff --
intendation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30854540
--- Diff: app/addons/activetasks/components.react.jsx ---
@@ -453,17 +384,71 @@ define([
<td>{startedOnMsg}</td>
<td>{updatedOnMsg}</td>
<td>{rowData.pid}</td>
- <td>{progressMsg}</td>
+ <td>{progressMsg}<ActiveTasksViewSourceSequence item={this.props.item}/></td>
</tr>
);
}
});
+ var ActiveTasksViewSourceSequence = React.createClass({
+ onTrayToggle: function (e) {
+ e.preventDefault();
+ this.refs.view_source_sequence_btn.toggle(function (shown) {
+ if (shown) {
+ this.refs.view_source_sequence_btn.getDOMNode().focus();
+ }
+ }.bind(this));
+ },
+
+ sequences: function (item) {
+ if (_.isNumber(item) ) {
+ return (
+ <ComponentsReact.ClipboardWithTextField textToCopy={item} uniqueKey={item}>
+ </ComponentsReact.ClipboardWithTextField>
+ );
+ } else if (_.isArray(item)) {
+ return (
+ _.map(item, function (seq, i) {
+ return (
+ <ComponentsReact.ClipboardWithTextField textToCopy={seq} uniqueKey={i + Math.random(100)} key={i}>
+ </ComponentsReact.ClipboardWithTextField>
+ );
+ })
+ );
+ }
+ },
+
+ render: function () {
+
+ if (_.has(this.props.item, 'source_seq')) {
+ var sequences = this.sequences(this.props.item.source_seq);
+ return (
+ <div>
+ Current source sequence:
+ <a href="#"
+ className="view-source-sequence-btn"
+ onClick={this.onTrayToggle}
+ data-bypass="true">
+ View
+ </a>
+ <ComponentsReact.Tray ref="view_source_sequence_btn" className="view_source_sequence_tray">
+ <span className="add-on">Source Sequence</span>
+ {sequences}
+ </ComponentsReact.Tray>
+ </div>
+ );
+ } else {
--- End diff --
you return early, no need for the else
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-93997534
Do you like the idea?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30429783
--- Diff: app/addons/activetasks/stores.js ---
@@ -28,6 +28,35 @@ define([
this._pollingIntervalSeconds = 5;
this.sortCollectionByColumnHeader(this._sortByHeader);
this._backboneCollection = backboneCollection;
+ this.setIsLoading(true);
+ },
+
+ isLoading: function () {
+ return this._isLoading;
+ },
+
+ setIsLoading: function (bool) {
+ this._isLoading = bool;
+ if (bool) {
+ this.startTimerForLoading();
+ } else {
+ this.stopTimerForLoading();
+ }
+ },
+
+ startTimerForLoading: function () {
+ this._clockForLoadingLines = 0;
+ this._clockForLoadingLinesID = setInterval(function () {
+ this._clockForLoadingLines++;
--- End diff --
yes, we can do that! :D I will implement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-94549604
i am toying with the idea of adding a condition which checks the delay, and only shows a delay if the fetch is very short.
That way on longer fetches, it actually stops when the fetch returns.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30854347
--- Diff: app/addons/activetasks/assets/less/activetasks.less ---
@@ -208,4 +205,64 @@ input[type="text"].searchbox {
padding: 0px;
margin: 0px;
}
+
+ .active-tasks-header {
+ background-color: #ccc;
+ }
+
+ .icon-caret-up, .icon-caret-down {
+ color: #af2d24;
+ }
+}
+
+.active-tasks-loading-lines {
+ padding-top: 15px;
+ float: left;
+ margin-left: -40px;
+
+ #line1, #line2, #line3, #line4 {
+ background-color: #bbb;
+ }
+}
+
+.view-source-sequence-btn { /*"View"*/
--- End diff --
// are not rendered in the final compiled CSS
/* */ is
please use //
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30985104
--- Diff: app/addons/activetasks/actions.js ---
@@ -16,17 +16,18 @@ define([
],
function (FauxtonAPI, ActionTypes, Resources) {
return {
- fetchAndSetActiveTasks: function (options) {
+ init: function (options) {
var activeTasks = options;
--- End diff --
You could remove this line if you changed the function declaration to `init: function (activeTasks) { `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-107828522
@michellephung could you rebase and then +1 if all tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30854221
--- Diff: app/addons/activetasks/stores.js ---
@@ -18,7 +18,7 @@ define([
var ActiveTasksStore = FauxtonAPI.Store.extend({
- init: function (collectionTable, backboneCollection) {
+ init_after_fetching: function (collectionTable, backboneCollection) {
--- End diff --
we use camelCase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30854525
--- Diff: app/addons/activetasks/components.react.jsx ---
@@ -453,17 +384,71 @@ define([
<td>{startedOnMsg}</td>
<td>{updatedOnMsg}</td>
<td>{rowData.pid}</td>
- <td>{progressMsg}</td>
+ <td>{progressMsg}<ActiveTasksViewSourceSequence item={this.props.item}/></td>
</tr>
);
}
});
+ var ActiveTasksViewSourceSequence = React.createClass({
+ onTrayToggle: function (e) {
+ e.preventDefault();
+ this.refs.view_source_sequence_btn.toggle(function (shown) {
+ if (shown) {
+ this.refs.view_source_sequence_btn.getDOMNode().focus();
+ }
+ }.bind(this));
+ },
+
+ sequences: function (item) {
+ if (_.isNumber(item) ) {
+ return (
+ <ComponentsReact.ClipboardWithTextField textToCopy={item} uniqueKey={item}>
+ </ComponentsReact.ClipboardWithTextField>
+ );
+ } else if (_.isArray(item)) {
--- End diff --
you return early here, no need for the else if?
what happens if it is not a number and not an array?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-103234498
I just noticed I changed the background color too dark. Will fix soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by sebastianrothbucher <gi...@git.apache.org>.
Github user sebastianrothbucher commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-100525727
I do like the way this works. Maybe the bar is a little shy and seems to hide away from the user, but I find it OK. I'd also find a darker shade of grey or so OK. I just have one place in the code I don't get (the Actions injection into Actions - see comment there). The other two comments are just suggestions (or I'm not getting it). Pls. let us know if you need a hand (also with tests and stuff - I can sure help there), otherwise, I think this leads in a very good direction (though some feedback above is still there).
Keep going!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/386
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-104439489
this needs a lot unit tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-104438055
Ready for reviews!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-104441337
the logic for the unit tests are already written with the conversion of active task to react, (and they are still passing!) :D
https://github.com/apache/couchdb-fauxton/blob/master/app/addons/activetasks/tests/activetasks.componentsSpec.react.jsx
https://github.com/apache/couchdb-fauxton/blob/master/app/addons/activetasks/tests/activetasks.storesSpec.js
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by sebastianrothbucher <gi...@git.apache.org>.
Github user sebastianrothbucher commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#discussion_r29994800
--- Diff: app/addons/activetasks/actions.js ---
@@ -14,13 +14,14 @@ define([
'addons/activetasks/actiontypes',
'addons/activetasks/resources'
],
-function (FauxtonAPI, ActionTypes, Resources) {
+function (FauxtonAPI, ActionTypes, Resources, Actions) {
--- End diff --
What do we need the Actions param for? (at least it does not match with above, and we _are_ w/in actions...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-93585776
comments and suggestions are welcome
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-94734074
@michellephung this is awesome. I think the loading lines might be a little too muted. It took me a while to finally notice where the loading lines were. Once you add tests I'm +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-105252973
@michellephung nice work this is great. One small change. After that +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-93959590
missing tests, will take a look when tests are present
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add loading lines to active tasks
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-94881151
Hey I got some feedback from the #couchdb-dev channel that I'm gonna incorporate into this branch.
1. Instead of 1 row per active task, 2 rows where the first row is: type/ source/target/ started/pid, then the second row is all the status information. It should free up more room since the status part is the cramped as it currently is.
2. Instead of radio buttons, tabs
3. move the search field into the header
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---