You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/03/16 23:42:38 UTC

[GitHub] pritidesai commented on issue #801: Adding Docker and Native support

pritidesai commented on issue #801: Adding Docker and Native support
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/801#issuecomment-373873222
 
 
   @mrutkows I think its beyond the scope of `wskdeploy`. We have repository and credentials defined [here](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/specification/openwhisk_v0.9.2.pdf) on line 558 and line 571. But with docker actions the way they are designed, images are not pulled during action creation. So even if we have access to credentials of private repo and we could pass that to OpenWhisk server but the its not supported by server side. 
   
   We can address this by what Rodric has commented here https://github.com/apache/incubator-openwhisk/issues/1362 saying "_One way to support this is by pulling images from the private registry to a whisk managed registry at action create time. This would avoid some the challenges around key management for docker login. In general I think this is a good approach for docker actions as it will make it easier for vetting images; but not without its demerits._" We can definitely add support for this in `wskdeploy`, is that what we are looking for?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services