You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/29 18:03:50 UTC

[GitHub] [arrow] zhztheplayer commented on a diff in pull request #13250: ARROW-16675: [C++] Wrong Tell() result from BufferedOutputStream in an edge case

zhztheplayer commented on code in PR #13250:
URL: https://github.com/apache/arrow/pull/13250#discussion_r884305834


##########
cpp/src/arrow/io/buffered_test.cc:
##########
@@ -293,6 +293,14 @@ TEST_F(TestBufferedOutputStream, Tell) {
 
   ASSERT_OK(buffered_->Close());
 
+  // write large buffer after raw_pos is cached
+  OpenBuffered(3, false);
+  AssertTell(0);
+  ASSERT_OK(buffered_->Write(std::string(10, '0').data(), 5));

Review Comment:
   Oops. Thanks for catching.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org