You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/06 14:05:14 UTC

[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #2485: [ISSUE #2338] use logger instead of prints the stack trace

jonyangx commented on code in PR #2485:
URL: https://github.com/apache/incubator-eventmesh/pull/2485#discussion_r1041019265


##########
eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/utils/CloudEventUtils.java:
##########
@@ -30,8 +30,13 @@
 import java.util.function.BiConsumer;
 import java.util.function.Function;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 public class CloudEventUtils {
 
+    private static final Logger log = LoggerFactory.getLogger(CloudEventUtils.class);

Review Comment:
   suggest replace log with LOGGER



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org