You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by jakubhavlik <gi...@git.apache.org> on 2017/01/17 08:41:53 UTC

[GitHub] flink pull request #3133: [FLINK-5518] [input/output formats] Add null value...

GitHub user jakubhavlik opened a pull request:

    https://github.com/apache/flink/pull/3133

    [FLINK-5518] [input/output formats] Add null value check.

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jakubhavlik/flink havlikj/flink_5518

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3133
    
----
commit 984b50fa0d85ab42c47692413d0bad331b363cab
Author: Jakub Havlik <ja...@brain-station.com>
Date:   2017-01-17T07:26:07Z

    [FLINK-5518] [input/output formats] Add null value check.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3133: [FLINK-5518] [input/output formats] Add null value check.

Posted by jakubhavlik <gi...@git.apache.org>.
Github user jakubhavlik commented on the issue:

    https://github.com/apache/flink/pull/3133
  
    Tests added and build passed: https://travis-ci.org/jakubhavlik/flink/builds/192653463 .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3133: [FLINK-5518] [input/output formats] Add null value check.

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3133
  
    Thanks for the quick update @jakubhavlik.
    +1 to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3133: [FLINK-5518] [input/output formats] Add null value check.

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3133
  
    Merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3133: [FLINK-5518] [input/output formats] Add null value check.

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3133
  
    Thanks for the PR @jakubhavlik.
    
    The fix looks good. Can you add a `testCloseWithoutOpen()` method to `org.apache.flink.api.java.hadoop.mapred.HadoopInputFormatTest` and `org.apache.flink.api.java.hadoop.mapreduce.HadoopInputFormatTest` to guard this fix?
    
    Occasionally builds fail due to timeouts. That's nothing to worry about. I'll run the tests again before merging.
    
    Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---