You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2023/05/18 07:11:30 UTC
[GitHub] [doris] yiguolei commented on a diff in pull request #19795: [fix](memory) `vm/overcommit_memory` defaults to 1 in start_be.sh
yiguolei commented on code in PR #19795:
URL: https://github.com/apache/doris/pull/19795#discussion_r1197482875
##########
bin/start_be.sh:
##########
@@ -20,6 +20,13 @@ set -eo pipefail
curdir="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
+if [ $(id -u) -eq 0 ]; then # current user has root privileges
+ # system will no longer throw bad_alloc, memory alloc are always accepted,
Review Comment:
maybe we should not do that. it's better to print a warning? or add the message to be.out?
but i am not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org