You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bval.apache.org by "jungm (via GitHub)" <gi...@apache.org> on 2024/04/13 18:38:53 UTC
[PR] [BVAL-220] Ensure Java 17 compatibility [bval]
jungm opened a new pull request, #107:
URL: https://github.com/apache/bval/pull/107
See [BVAL-220](https://issues.apache.org/jira/browse/BVAL-220)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bval.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BVAL-220] Ensure Java 17/21 compatibility [bval]
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko merged PR #107:
URL: https://github.com/apache/bval/pull/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bval.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BVAL-220] Ensure Java 17 compatibility [bval]
Posted by "jungm (via GitHub)" <gi...@apache.org>.
jungm commented on PR #107:
URL: https://github.com/apache/bval/pull/107#issuecomment-2054106897
Fixed the build for java 21 now as well 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bval.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BVAL-220] Ensure Java 17 compatibility [bval]
Posted by "jungm (via GitHub)" <gi...@apache.org>.
jungm commented on code in PR #107:
URL: https://github.com/apache/bval/pull/107#discussion_r1564785288
##########
bval-jsr/src/main/java/org/apache/bval/jsr/metadata/Meta.java:
##########
@@ -354,11 +354,12 @@ public boolean equals(Object obj) {
if (!obj.getClass().equals(getClass())) {
Review Comment:
removed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bval.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BVAL-220] Ensure Java 17 compatibility [bval]
Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on code in PR #107:
URL: https://github.com/apache/bval/pull/107#discussion_r1564214812
##########
bval-jsr/src/main/java/org/apache/bval/jsr/metadata/Meta.java:
##########
@@ -354,11 +354,12 @@ public boolean equals(Object obj) {
if (!obj.getClass().equals(getClass())) {
Review Comment:
guess we would like to have a real equals/hashcode
what about just dropping both and use identity default impl, should be sufficient since meta should be cached per reflection instance in bval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bval.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org