[jira] [Commented] (ASTERIXDB-1949) Scan feed connections when drop-function and drop-dataverse

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ASTERIXDB-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106181#comment-16106181 ] 

ASF subversion and git services commented on ASTERIXDB-1949:
------------------------------------------------------------

Commit f4e755e4b3b8fe853d1ac404697f4a83540f14f0 in asterixdb's branch refs/heads/master from [~idleft]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=f4e755e ]

[ASTERIXDB-1949][FUN][ING] Function usage check refactoring in feed

- user model changes: no
- storage format changes: no
- interface changes: yes
   Removed several interefaces for maintaining reference count.
   Added getFunctions and getFeeds method for MetadataNode.

Details:

1. Change the usage check from reference count to scan feed connections
   in all dataverses.
2. Add test case for drop dataverse which has function that is being
   used in other dataverse. This operation should be blocked.
3. Fix small bug in apply function metadata which the function dataverse
   was not recorded properly.

Change-Id: I568f7af18e69216ff2a5fd3b623a1667809b2f95
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1787
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
BAD: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: abdullah alamoudi <ba...@gmail.com>


> Scan feed connections when drop-function and drop-dataverse
> -----------------------------------------------------------
>
>                 Key: ASTERIXDB-1949
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1949
>             Project: Apache AsterixDB
>          Issue Type: Improvement
>            Reporter: Xikui Wang
>            Assignee: Xikui Wang
>
> In the previous change about the function usage check[1], the logic of function usage check becomes complicated when there is cross-referencing of functions between dataverses. After several discussions, we decided to change the check back to scan all possible usages in feed connections, instead of maintaining a reference count in metadata. Two scenarios are covered by this change:
> 1. If a dataverse has functions that are used by others, the drop-dataverse statement will be prevented.
> 2. If a function is used by any other feed connections, the drop-function statement will be prevented.
> [1] https://asterix-gerrit.ics.uci.edu/1763



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)