[GitHub] [incubator-shardingsphere] yanyzy commented on a change in pull request #3702: [Shadow] add yaml configuration & rule

[GitBox <gi...@apache.org>]

yanyzy commented on a change in pull request #3702: [Shadow] add yaml configuration & rule
URL: https://github.com/apache/incubator-shardingsphere/pull/3702#discussion_r355875423
 
 

 ##########
 File path: sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShadowRule.java
 ##########
 @@ -18,18 +18,30 @@
 package org.apache.shardingsphere.core.rule;
 
 import lombok.Getter;
-import org.apache.shardingsphere.api.config.RuleConfiguration;
+import org.apache.shardingsphere.api.config.shadow.ShadowRuleConfiguration;
 
 /**
  * Databases shadow rule.
  *
  * @author zhyee
+ * @author xiayan
  */
 @Getter
 public class ShadowRule implements BaseRule {
-
-    @Override
-    public final RuleConfiguration getRuleConfiguration() {
-        return null;
+    
+    @Getter
 
 Review comment:
   This class already has the @Getter , is that a repetition ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services