[jira] [Comment Edited] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

["Georg Henzler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998028#comment-15998028 ] 

Georg Henzler edited comment on SLING-6804 at 5/5/17 10:54 AM:
---------------------------------------------------------------

Spaces in {{hc.name}} have to be URL-encoded which is not that nice to look at, however thinking about it more using {{hc.name}} has a big advantage: It can be changed by configuration and for the case it is a service factory HC, the name is usually still unique (while the class name is not). 

Regarding the patch: I would not like to change the interface of the HC executor, it is a lot easier to just have one "search field" (=one parameter in the URL, more modern like google :) ). Also the patch does not include the change for the webconsole yet. 

So I would propose to just implicitly add the HC name to the tags and use URLs like the following:
{{/system/health/myTagForAllChecks,-Name%20of%20the%20one%20HC%20to%20exclude}}

Also this makes the implementation a lot easier, see [^SLING-6804-allow-hc.name-in-hc-urls-simple.patch] (javadoc and executor servlet help would have to be updated as well, would do that after this patch is applied)


was (Author: henzlerg):
Spaces in {{hc.name}} have to be URL-encoded which is not that nice to look at, however thinking about it more using {{hc.name}} has a big advantage: It can be changed by configuration and for the case it is a service factory HC, the name is usually still unique (while the class name is not). 

Regarding the patch: I would not like to change the interface of the HC executor, it is a lot easier to just have one "search field" (=one parameter in the URL, more modern like google :) ). Also the patch does not include the change for the webconsole yet. 

So I would propose to just implicitly add the HC name to the tags and use URLs like the following:
{{/system/health/myTagForAllChecks,-Name%20of%20the%20one%20HC%20to%20exclude}}

Also this makes the implementation a lot easier, preparing a simple patch for it.

> Request to allow the health check servlet to directly query a single health check by name
> -----------------------------------------------------------------------------------------
>
>                 Key: SLING-6804
>                 URL: https://issues.apache.org/jira/browse/SLING-6804
>             Project: Sling
>          Issue Type: Improvement
>          Components: Health Check
>            Reporter: Clinton H Goudie-Nice
>            Assignee: Justin Edelson
>            Priority: Minor
>         Attachments: SLING-6804-allow-hc.name-in-hc-urls-simple.patch, SLING-6804.diff
>
>
> AMS has a request to be able to access an individual health check by name
> For example: 
> http://localhost:4502/system/health/named/Sling%20Get%20Servlet.json
> And have it return the results for only this named health check.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)