You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/24 10:56:17 UTC
[GitHub] [flink] slinkydeveloper opened a new pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
slinkydeveloper opened a new pull request #17350:
URL: https://github.com/apache/flink/pull/17350
Signed-off-by: slinkydeveloper <fr...@gmail.com>
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Migrate `AbstractFileSystemTable` to use the new `ResolvedSchema` APIs
## Brief change log
- Now `AbstractFileSystemTable` and inheritors use the new `ResolvedSchema` APIs. Some usage of the old `TableSchema` persists because it's required by the `FileSystemFormatFactory.ReaderContext` class, but it will be easy to remove once `FileSystemFormatFactory` will be pruned.
## Verifying this change
This change is already covered by existing tests in `org.apache.flink.table.filesystem`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-934136568
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17350:
URL: https://github.com/apache/flink/pull/17350#discussion_r724214646
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java
##########
@@ -331,7 +338,7 @@ private RowDataPartitionComputer partitionComputer() {
return new FileSystemFormatFactory.ReaderContext() {
@Override
public TableSchema getSchema() {
Review comment:
good point, haven't seen that is deprecated. then we don't need to do the effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17350:
URL: https://github.com/apache/flink/pull/17350#discussion_r716418986
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSource.java
##########
@@ -164,7 +167,7 @@ private SourceProvider createSourceProvider(BulkFormat<RowData, FileSourceSplit>
@Override
public TableSchema getSchema() {
- return schema;
+ return TableSchema.fromResolvedSchema(schema);
Review comment:
This code path should be hit if you're using the deprecated `FileSystemFormatFactory`, used only by csv and avro formats. As a followup I can work on migrating these 2 to the new factories, so we can prune this code completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17350:
URL: https://github.com/apache/flink/pull/17350#discussion_r724214646
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java
##########
@@ -331,7 +338,7 @@ private RowDataPartitionComputer partitionComputer() {
return new FileSystemFormatFactory.ReaderContext() {
@Override
public TableSchema getSchema() {
Review comment:
good point, haven't seen that is deprecated. then we don't need to do the effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
}, {
"hash" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590",
"triggerID" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c367e2f75e474e41401f759591d8a357fd75840 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562)
* e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587)
* 18e0e605662773415554f5fa1c1ad7520620ab8e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98fac3d3a2b3e3c79cbea8625625faee50b16de8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480)
* 92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522)
* 8829be9b9a5b8ec95c8940853e7abd7f174ddf7b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17350:
URL: https://github.com/apache/flink/pull/17350#discussion_r716431275
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/AbstractFileSystemTable.java
##########
@@ -59,15 +68,19 @@ ReadableConfig formatOptions(String identifier) {
return new DelegatingConfiguration(tableOptions, identifier + ".");
}
- DataType getFormatDataType() {
- TableSchema.Builder builder = TableSchema.builder();
- schema.getTableColumns()
- .forEach(
- column -> {
- if (!partitionKeys.contains(column.getName())) {
- builder.add(column);
- }
- });
- return builder.build().toRowDataType();
+ DataType getRowDataTypeWithoutPartitionColumns() {
Review comment:
TBH I find less convoluted the committed code than extracting the info from `getRowDataType()`:
```java
FieldsDataType fieldsDataType = (FieldsDataType) getRowDataType();
RowType rowType = (RowType) getRowDataType().getLogicalType();
return ROW(
IntStream.range(0, rowType.getFieldCount())
.filter(i -> !partitionKeys.contains(rowType.getFieldNames().get(i)))
.mapToObj(i -> DataTypes.FIELD(rowType.getFieldNames().get(i), fieldsDataType.getChildren().get(i)))
.toArray(DataTypes.Field[]::new)
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
}, {
"hash" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590",
"triggerID" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24765",
"triggerID" : "934136568",
"triggerType" : "MANUAL"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "934136568",
"triggerType" : "MANUAL"
}, {
"hash" : "0a0cd972b9e8406a06ead5f7e9c8fd161340a625",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0cd972b9e8406a06ead5f7e9c8fd161340a625",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 94928a167b2a189c2b3a20bbf5205fdcb016065f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24765) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754)
* 0a0cd972b9e8406a06ead5f7e9c8fd161340a625 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
}, {
"hash" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590",
"triggerID" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24765",
"triggerID" : "934136568",
"triggerType" : "MANUAL"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "934136568",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 94928a167b2a189c2b3a20bbf5205fdcb016065f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24765) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98fac3d3a2b3e3c79cbea8625625faee50b16de8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17350:
URL: https://github.com/apache/flink/pull/17350#discussion_r715632847
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/AbstractFileSystemTable.java
##########
@@ -49,7 +54,11 @@
this.tableIdentifier = context.getObjectIdentifier();
this.tableOptions = new Configuration();
context.getCatalogTable().getOptions().forEach(tableOptions::setString);
- this.schema = TableSchemaUtils.getPhysicalSchema(context.getCatalogTable().getSchema());
+ this.schema = context.getCatalogTable().getResolvedSchema();
+ this.physicalColumns =
Review comment:
This seems redundant, since `schema` contains this entirely.
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/DeserializationSchemaAdapter.java
##########
@@ -73,31 +73,32 @@
public DeserializationSchemaAdapter(
DeserializationSchema<RowData> deserializationSchema,
- TableSchema schema,
+ List<Column> physicalColumns,
Review comment:
We should just pass the (physical) `DataType` here and keep that. It contains both names and types.
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/AbstractFileSystemTable.java
##########
@@ -59,15 +68,19 @@ ReadableConfig formatOptions(String identifier) {
return new DelegatingConfiguration(tableOptions, identifier + ".");
}
- DataType getFormatDataType() {
- TableSchema.Builder builder = TableSchema.builder();
- schema.getTableColumns()
- .forEach(
- column -> {
- if (!partitionKeys.contains(column.getName())) {
- builder.add(column);
- }
- });
- return builder.build().toRowDataType();
+ DataType getRowDataTypeWithoutPartitionColumns() {
Review comment:
This can be entirely derived from `getRowDataType` by using `getRowDataType().getLogicalType()` which is always `RowType` and has all the information.
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSource.java
##########
@@ -164,7 +167,7 @@ private SourceProvider createSourceProvider(BulkFormat<RowData, FileSourceSplit>
@Override
public TableSchema getSchema() {
- return schema;
+ return TableSchema.fromResolvedSchema(schema);
Review comment:
So migrating this isn't needed to fix the issue you had encountered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8829be9b9a5b8ec95c8940853e7abd7f174ddf7b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527)
* 8c367e2f75e474e41401f759591d8a357fd75840 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8829be9b9a5b8ec95c8940853e7abd7f174ddf7b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-927639595
@Airblader I've refactored the usages of schema and column to use `DataType` as much as possible, so once we get rid of `FileSystemFormatFactory` we can remove the usage of `Schema` inside the `AbstractFileSystemTable` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
}, {
"hash" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590",
"triggerID" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24765",
"triggerID" : "934136568",
"triggerType" : "MANUAL"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "934136568",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 94928a167b2a189c2b3a20bbf5205fdcb016065f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24765) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c367e2f75e474e41401f759591d8a357fd75840 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562)
* e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
}, {
"hash" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590",
"triggerID" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24765",
"triggerID" : "934136568",
"triggerType" : "MANUAL"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "934136568",
"triggerType" : "MANUAL"
}, {
"hash" : "0a0cd972b9e8406a06ead5f7e9c8fd161340a625",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24806",
"triggerID" : "0a0cd972b9e8406a06ead5f7e9c8fd161340a625",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a0cd972b9e8406a06ead5f7e9c8fd161340a625 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24806)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-927639595
@Airblader I've refactored the usages of schema and column to just use `DataType`, so once we get rid of `FileSystemFormatFactory` we can remove the usage of `Schema` inside the `AbstractFileSystemTable` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17350:
URL: https://github.com/apache/flink/pull/17350#discussion_r723486705
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java
##########
@@ -331,7 +338,7 @@ private RowDataPartitionComputer partitionComputer() {
return new FileSystemFormatFactory.ReaderContext() {
@Override
public TableSchema getSchema() {
Review comment:
I don't think we should, because the `FileSystemFormatFactory` is deprecated and we need to prune it anyway. I was thinking to do that in a separate issue (there are only 2 implementations for that, avro and csv IIRC)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
}, {
"hash" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590",
"triggerID" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 94928a167b2a189c2b3a20bbf5205fdcb016065f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522)
* 8829be9b9a5b8ec95c8940853e7abd7f174ddf7b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98fac3d3a2b3e3c79cbea8625625faee50b16de8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480)
* 92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
}, {
"hash" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c367e2f75e474e41401f759591d8a357fd75840 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562)
* e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587)
* 18e0e605662773415554f5fa1c1ad7520620ab8e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98fac3d3a2b3e3c79cbea8625625faee50b16de8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17350:
URL: https://github.com/apache/flink/pull/17350#discussion_r716420751
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSource.java
##########
@@ -164,7 +167,7 @@ private SourceProvider createSourceProvider(BulkFormat<RowData, FileSourceSplit>
@Override
public TableSchema getSchema() {
- return schema;
+ return TableSchema.fromResolvedSchema(schema);
Review comment:
It's probably fine to leave that for now. That stack is deprecated as well anyway, so migrating it to the new Schema stack is probably not worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
}, {
"hash" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590",
"triggerID" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24765",
"triggerID" : "934136568",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 94928a167b2a189c2b3a20bbf5205fdcb016065f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24765)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
}, {
"hash" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590",
"triggerID" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24765",
"triggerID" : "934136568",
"triggerType" : "MANUAL"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "934136568",
"triggerType" : "MANUAL"
}, {
"hash" : "0a0cd972b9e8406a06ead5f7e9c8fd161340a625",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24806",
"triggerID" : "0a0cd972b9e8406a06ead5f7e9c8fd161340a625",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 94928a167b2a189c2b3a20bbf5205fdcb016065f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24765) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754)
* 0a0cd972b9e8406a06ead5f7e9c8fd161340a625 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24806)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17350:
URL: https://github.com/apache/flink/pull/17350#discussion_r716431275
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/AbstractFileSystemTable.java
##########
@@ -59,15 +68,19 @@ ReadableConfig formatOptions(String identifier) {
return new DelegatingConfiguration(tableOptions, identifier + ".");
}
- DataType getFormatDataType() {
- TableSchema.Builder builder = TableSchema.builder();
- schema.getTableColumns()
- .forEach(
- column -> {
- if (!partitionKeys.contains(column.getName())) {
- builder.add(column);
- }
- });
- return builder.build().toRowDataType();
+ DataType getRowDataTypeWithoutPartitionColumns() {
Review comment:
TBH I find less convoluted the committed code than extracting the info from `getRowDataType()`:
```java
FieldsDataType fieldsDataType = (FieldsDataType) getRowDataType();
RowType rowType = (RowType) getRowDataType().getLogicalType();
return ROW(
IntStream.range(0, rowType.getFieldCount())
.filter(i -> !partitionKeys.contains(rowType.getFieldNames().get(i)))
.mapToObj(i -> DataTypes.FIELD(rowType.getFieldNames().get(i), fieldsDataType.getChildren().get(i)))
.toArray(DataTypes.Field[]::new)
);
```
Same for the comment in `DeserializationSchemaAdapter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17350:
URL: https://github.com/apache/flink/pull/17350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17350:
URL: https://github.com/apache/flink/pull/17350#discussion_r716445907
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/AbstractFileSystemTable.java
##########
@@ -59,15 +68,19 @@ ReadableConfig formatOptions(String identifier) {
return new DelegatingConfiguration(tableOptions, identifier + ".");
}
- DataType getFormatDataType() {
- TableSchema.Builder builder = TableSchema.builder();
- schema.getTableColumns()
- .forEach(
- column -> {
- if (!partitionKeys.contains(column.getName())) {
- builder.add(column);
- }
- });
- return builder.build().toRowDataType();
+ DataType getRowDataTypeWithoutPartitionColumns() {
Review comment:
Oh wait I've found some utils to make this code look cleaner, let me refactor it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
}, {
"hash" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590",
"triggerID" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18e0e605662773415554f5fa1c1ad7520620ab8e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590)
* 94928a167b2a189c2b3a20bbf5205fdcb016065f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17350:
URL: https://github.com/apache/flink/pull/17350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c367e2f75e474e41401f759591d8a357fd75840 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562)
* e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98fac3d3a2b3e3c79cbea8625625faee50b16de8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
}, {
"hash" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590",
"triggerID" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587)
* 18e0e605662773415554f5fa1c1ad7520620ab8e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926536168
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 98fac3d3a2b3e3c79cbea8625625faee50b16de8 (Fri Sep 24 10:58:43 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24359).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
}, {
"hash" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590",
"triggerID" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24765",
"triggerID" : "934136568",
"triggerType" : "MANUAL"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24754",
"triggerID" : "934136568",
"triggerType" : "MANUAL"
}, {
"hash" : "0a0cd972b9e8406a06ead5f7e9c8fd161340a625",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24806",
"triggerID" : "0a0cd972b9e8406a06ead5f7e9c8fd161340a625",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a0cd972b9e8406a06ead5f7e9c8fd161340a625 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24806)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98fac3d3a2b3e3c79cbea8625625faee50b16de8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480)
* 92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522)
* 8829be9b9a5b8ec95c8940853e7abd7f174ddf7b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c367e2f75e474e41401f759591d8a357fd75840 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17350:
URL: https://github.com/apache/flink/pull/17350#discussion_r723166638
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/AbstractFileSystemTable.java
##########
@@ -39,7 +39,8 @@
final DynamicTableFactory.Context context;
final ObjectIdentifier tableIdentifier;
final Configuration tableOptions;
- final TableSchema schema;
+ final ResolvedSchema schema;
Review comment:
both schema and dataType can now be easily obtained from the `context` member, we don't need additional members and keep the code short and simple
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/DeserializationSchemaAdapter.java
##########
@@ -73,31 +72,32 @@
public DeserializationSchemaAdapter(
DeserializationSchema<RowData> deserializationSchema,
- TableSchema schema,
+ DataType physicalDataType,
int[] projectFields,
List<String> partitionKeys,
String defaultPartValue) {
this.deserializationSchema = deserializationSchema;
- this.fieldNames = schema.getFieldNames();
- this.fieldTypes = schema.getFieldDataTypes();
+ final RowType rowType = ((RowType) physicalDataType.getLogicalType());
Review comment:
nit: use the `DataType.getFieldNames` method and the streams API? also for the types?
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSource.java
##########
@@ -310,20 +316,18 @@ public String asSummaryString() {
private int[] readFields() {
return projectedFields == null
- ? IntStream.range(0, schema.getFieldCount()).toArray()
+ ? IntStream.range(0, DataType.getFieldCount(getPhysicalDataType())).toArray()
: Arrays.stream(projectedFields).mapToInt(array -> array[0]).toArray();
}
- private DataType getProducedDataType() {
- int[] fields = readFields();
- String[] schemaFieldNames = schema.getFieldNames();
- DataType[] schemaTypes = schema.getFieldDataTypes();
-
- return DataTypes.ROW(
- Arrays.stream(fields)
- .mapToObj(i -> DataTypes.FIELD(schemaFieldNames[i], schemaTypes[i]))
- .toArray(DataTypes.Field[]::new))
- .bridgedTo(RowData.class)
- .notNull();
+ private DataType getProjectedDataType() {
+ DataType physicalDataType = super.getPhysicalDataType();
Review comment:
nit: could be `final`
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java
##########
@@ -158,8 +159,8 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context sinkContext) {
private RowDataPartitionComputer partitionComputer() {
return new RowDataPartitionComputer(
defaultPartName,
- schema.getFieldNames(),
- schema.getFieldDataTypes(),
+ DataType.getFieldNames(getPhysicalDataType()).toArray(new String[] {}),
Review comment:
nit: in Flink we usually use `toArray(new String[0])` instead of `toArray(new String[] {})`
see https://stackoverflow.com/questions/9572795/convert-list-to-array-in-java
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java
##########
@@ -331,7 +338,7 @@ private RowDataPartitionComputer partitionComputer() {
return new FileSystemFormatFactory.ReaderContext() {
@Override
public TableSchema getSchema() {
Review comment:
can we update this to `DataType`? it would be good to get rid of `TableSchemaUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8829be9b9a5b8ec95c8940853e7abd7f174ddf7b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527)
* 8c367e2f75e474e41401f759591d8a357fd75840 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17350:
URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24480",
"triggerID" : "98fac3d3a2b3e3c79cbea8625625faee50b16de8",
"triggerType" : "PUSH"
}, {
"hash" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24522",
"triggerID" : "92bef8d45d7ef5bc445fdd40d30ee1dfcc36b42d",
"triggerType" : "PUSH"
}, {
"hash" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24527",
"triggerID" : "8829be9b9a5b8ec95c8940853e7abd7f174ddf7b",
"triggerType" : "PUSH"
}, {
"hash" : "8c367e2f75e474e41401f759591d8a357fd75840",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24562",
"triggerID" : "8c367e2f75e474e41401f759591d8a357fd75840",
"triggerType" : "PUSH"
}, {
"hash" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24587",
"triggerID" : "e5b7b89cfc5d51fcac2652c92c24a4e68f7f0963",
"triggerType" : "PUSH"
}, {
"hash" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590",
"triggerID" : "18e0e605662773415554f5fa1c1ad7520620ab8e",
"triggerType" : "PUSH"
}, {
"hash" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "94928a167b2a189c2b3a20bbf5205fdcb016065f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18e0e605662773415554f5fa1c1ad7520620ab8e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24590)
* 94928a167b2a189c2b3a20bbf5205fdcb016065f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org