You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by "gregh3269 (via GitHub)" <gi...@apache.org> on 2023/03/22 14:52:08 UTC
[GitHub] [roller] gregh3269 opened a new pull request, #124: Upgrade to struts 6.1.2
gregh3269 opened a new pull request, #124:
URL: https://github.com/apache/roller/pull/124
From my testing of the UI this is all it needs to get to the latest version. Were there any failing tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [roller] gregh3269 closed pull request #124: Upgrade to struts 6.1.2
Posted by "gregh3269 (via GitHub)" <gi...@apache.org>.
gregh3269 closed pull request #124: Upgrade to struts 6.1.2
URL: https://github.com/apache/roller/pull/124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [roller] mbien commented on pull request #124: Upgrade to struts 6.1.2
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #124:
URL: https://github.com/apache/roller/pull/124#issuecomment-1494635543
you are saying that struts 2.5.30+ is not compatible with the bootstrap (plugin) version roller uses at the moment? I assumed it might have something to do with the double evaluation fix which is mentioned on the struts release notes. I hoped there might be a chance to update struts without bootstrap for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [roller] gregh3269 commented on pull request #124: Upgrade to struts 6.1.2
Posted by "gregh3269 (via GitHub)" <gi...@apache.org>.
gregh3269 commented on PR #124:
URL: https://github.com/apache/roller/pull/124#issuecomment-1481086666
Your are probably right here. Looking into this more, I did not realise the dependency soup with the bootstrap plugin. Plugin v5.00 uses bootstrap v5.2.0 where roller is using v3.4.1.
Now I realise Dave email. I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [roller] gregh3269 commented on pull request #124: Upgrade to struts 6.1.2
Posted by "gregh3269 (via GitHub)" <gi...@apache.org>.
gregh3269 commented on PR #124:
URL: https://github.com/apache/roller/pull/124#issuecomment-1480909793
Checking the page the id has extra underscores. I will check if this is intentional.
<input type="submit" value="Post to Weblog" id="entry____mainAction__publish" name="action:entryEdit!publish" class="btn btn-success">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [roller] mbien commented on pull request #124: Upgrade to struts 6.1.2
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #124:
URL: https://github.com/apache/roller/pull/124#issuecomment-1480832131
> Were there any failing tests?
yes. see CI. Or try starting roller and open the management UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [roller] gregh3269 commented on pull request #124: Upgrade to struts 6.1.2
Posted by "gregh3269 (via GitHub)" <gi...@apache.org>.
gregh3269 commented on PR #124:
URL: https://github.com/apache/roller/pull/124#issuecomment-1495450849
Yes. The plugin needs some updates. If you compare branches you can see what's needed. Relatively simple in comparison to redoing bootstrap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [roller] mbien commented on pull request #124: Upgrade to struts 6.1.2
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #124:
URL: https://github.com/apache/roller/pull/124#issuecomment-1480915374
i wouldn't recommend to skip so many major versions at once, this rarely works. The very next minor release already causes problems.
migration guide
https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [roller] gregh3269 commented on pull request #124: Upgrade to struts 6.1.2
Posted by "gregh3269 (via GitHub)" <gi...@apache.org>.
gregh3269 commented on PR #124:
URL: https://github.com/apache/roller/pull/124#issuecomment-1493876478
Looking more into this there does not seem much of a lifeboat wrt the plugin. The general consensus is it is not possible upgrade this version of bootstrap (no surprise) . Seems a lot of changes on every major release, not the best use of resources. I did some testing and its not too difficult modify 4.0.1 to work with for example 6.1.2. A lot easier than upgrading bootstrap.
See branch 4.0.2-struts-6.1.2.
How to go forward with this is another question, maybe importing the code into roller??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org