[GitHub] [druid] imply-cheddar commented on a diff in pull request #13568: improve nested column storage format for broader compatibility

[GitBox <gi...@apache.org>]

imply-cheddar commented on code in PR #13568:
URL: https://github.com/apache/druid/pull/13568#discussion_r1049218609


##########
processing/src/main/java/org/apache/druid/query/expression/NestedDataExpressions.java:
##########
@@ -500,9 +501,10 @@ public ExprEval eval(ObjectBinding bindings)
           // maybe in the future ProcessResults should deal in PathFinder.PathPart instead of strings for fields
           StructuredDataProcessor.ProcessResults info = processor.processFields(unwrap(input));
           List<String> transformed = info.getLiteralFields()
-                                        .stream()
-                                        .map(p -> NestedPathFinder.toNormalizedJsonPath(NestedPathFinder.parseJqPath(p)))
-                                        .collect(Collectors.toList());
+                                         .stream()
+                                         .map(NestedPathFinder::toNormalizedJsonPath)
+                                         .sorted()

Review Comment:
   is it not possible to have a `sort` expression that you can use when testing and can live externally to this?  I worry about forced sorting...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org