You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by huafengw <gi...@git.apache.org> on 2017/10/18 11:20:34 UTC
[GitHub] incubator-gearpump pull request #232: [GEARPUMP-358] Decrease the frequency ...
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/232
[GEARPUMP-358] Decrease the frequency of watermark calculation
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huafengw/incubator-gearpump regre
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/232.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #232
----
commit 3456bfcfe1fa643f37dedbb88c6e4090d6df5823
Author: huafengw <fv...@gmail.com>
Date: 2017-10-18T11:19:44Z
[GEARPUMP-358] Decrease the frequency of watermark calculation
----
---
[GitHub] incubator-gearpump issue #232: [GEARPUMP-358] Decrease the frequency of wate...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/232
LGTM
---
[GitHub] incubator-gearpump pull request #232: [GEARPUMP-358] Decrease the frequency ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/232
---
[GitHub] incubator-gearpump issue #232: [GEARPUMP-358] Decrease the frequency of wate...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/232
# [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/232?src=pr&el=h1) Report
> Merging [#232](https://codecov.io/gh/apache/incubator-gearpump/pull/232?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/175b08e64c3363a2da9c61e05dac5f01d1f8db2d?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `40%`.
```diff
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 69.01% 68.96% -0.05%
==========================================
Files 191 191
Lines 6119 6123 +4
Branches 358 357 -1
==========================================
Hits 4223 4223
- Misses 1896 1900 +4
```
---