You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Butao Zhang <bu...@163.com> on 2024/11/24 08:31:48 UTC

[Discuss] Should we remove the auto-assign reviewer github-actions?

Hi folks,


            HIVE-24525 added the github-actions which can auto assign reviewers for some PR. It's good If some hive committers are always active in the community.
            But in recent years, some folks seem to be away hive community[1]. Howerver, the github-actions keeps assigning PR to them automatically, which gives new contributors the misconception that their requests will be processed by these folks who have left.  I don't see this auto-assign feature working very well.
 
            I think we should remove the auto-assign github-actions. Please tell me if you have a better idea.
            
[1] https://github.com/apache/hive/blob/master/.github/assign-by-files.yml


Thanks,
Butao Zhang

Re: [Discuss] Should we remove the auto-assign reviewer github-actions?

Posted by Butao Zhang <zh...@apache.org>.

Thanks Ayush&Stamatis for your input! I have created the ticket to remove the auto-assign github-actions. Please check it. Thx.

https://issues.apache.org/jira/browse/HIVE-28647
https://github.com/apache/hive/pull/5564


Thanks,
 Butao Zhang

On 2024/11/25 08:44:28 Stamatis Zampetakis wrote:
> In the past it was used by some people but I guess it's not the case
> anymore. It could be a helpful feature but if noone is using it then
> we can definitely drop it. If needed we can bring it back again later
> on.
> 
> Best,
> Stamatis
> 
> On Sun, Nov 24, 2024 at 9:35 AM Ayush Saxena <ay...@gmail.com> wrote:
> >
> > +1, that was in my mind since long, that doesn’t work the way it was supposed to. At worst if people object to the idea of dropping it, let’s drop the inactive folks atleast
> >
> > -Ayush
> >
> > On 24 Nov 2024, at 2:01 PM, Butao Zhang <bu...@163.com> wrote:
> >
> > 
> > Hi folks,
> >
> >             HIVE-24525 added the github-actions which can auto assign reviewers for some PR. It's good If some hive committers are always active in the community.
> >             But in recent years, some folks seem to be away hive community[1]. Howerver, the github-actions keeps assigning PR to them automatically, which gives new contributors the misconception that their requests will be processed by these folks who have left.  I don't see this auto-assign feature working very well.
> >
> >             I think we should remove the auto-assign github-actions. Please tell me if you have a better idea.
> >
> > [1] https://github.com/apache/hive/blob/master/.github/assign-by-files.yml
> >
> > Thanks,
> > Butao Zhang
>

Re: [Discuss] Should we remove the auto-assign reviewer github-actions?

Posted by Stamatis Zampetakis <za...@apache.org>.

In the past it was used by some people but I guess it's not the case
anymore. It could be a helpful feature but if noone is using it then
we can definitely drop it. If needed we can bring it back again later
on.

Best,
Stamatis

On Sun, Nov 24, 2024 at 9:35 AM Ayush Saxena <ay...@gmail.com> wrote:
>
> +1, that was in my mind since long, that doesn’t work the way it was supposed to. At worst if people object to the idea of dropping it, let’s drop the inactive folks atleast
>
> -Ayush
>
> On 24 Nov 2024, at 2:01 PM, Butao Zhang <bu...@163.com> wrote:
>
> 
> Hi folks,
>
>             HIVE-24525 added the github-actions which can auto assign reviewers for some PR. It's good If some hive committers are always active in the community.
>             But in recent years, some folks seem to be away hive community[1]. Howerver, the github-actions keeps assigning PR to them automatically, which gives new contributors the misconception that their requests will be processed by these folks who have left.  I don't see this auto-assign feature working very well.
>
>             I think we should remove the auto-assign github-actions. Please tell me if you have a better idea.
>
> [1] https://github.com/apache/hive/blob/master/.github/assign-by-files.yml
>
> Thanks,
> Butao Zhang

Re: [Discuss] Should we remove the auto-assign reviewer github-actions?

Posted by Ayush Saxena <ay...@gmail.com>.

+1, that was in my mind since long, that doesn’t work the way it was supposed to. At worst if people object to the idea of dropping it, let’s drop the inactive folks atleast

-Ayush

> On 24 Nov 2024, at 2:01 PM, Butao Zhang <bu...@163.com> wrote:
> 
> 
> Hi folks,
> 
>             HIVE-24525 added the github-actions which can auto assign reviewers for some PR. It's good If some hive committers are always active in the community.
>             But in recent years, some folks seem to be away hive community[1]. Howerver, the github-actions keeps assigning PR to them automatically, which gives new contributors the misconception that their requests will be processed by these folks who have left.  I don't see this auto-assign feature working very well.
>  
>             I think we should remove the auto-assign github-actions. Please tell me if you have a better idea.
>             
> [1] https://github.com/apache/hive/blob/master/.github/assign-by-files.yml
> 
> Thanks,
> Butao Zhang