You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/11/06 12:47:15 UTC
[GitHub] nvazquez commented on a change in pull request #2995: Improvements
on upload direct download certificates
nvazquez commented on a change in pull request #2995: Improvements on upload direct download certificates
URL: https://github.com/apache/cloudstack/pull/2995#discussion_r231108544
##########
File path: agent/src/com/cloud/agent/Agent.java
##########
@@ -697,16 +697,34 @@ private Answer setupDirectDownloadCertificate(SetupDirectDownloadCertificate cmd
final String keyStoreFile = agentFile.getParent() + "/" + KeyStoreUtils.KS_FILENAME;
- String cerFile = agentFile.getParent() + "/" + certificateName + ".cer";
- Script.runSimpleBashScript(String.format("echo '%s' > %s", certificate, cerFile));
+ String cerFile = agentFile.getParent() + "/" + "CSCERTIFICATE-" + certificateName;
Review comment:
This is to make sure the certificate is created into a non existing file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services