You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2023/02/01 14:30:00 UTC
[GitHub] [arrow] raulcd opened a new issue, #33977: [Dev] Implement automation bot for PRs
raulcd opened a new issue, #33977:
URL: https://github.com/apache/arrow/issues/33977
### Describe the enhancement requested
I would like to start working on some automation for our PRs workflow.
I've heard, and have experienced, the frustration to spend a lot of time on our issue tracker and our PRs to follow up on their status. It is very hard to keep track of which PRs and issues are waiting for user feedback, have gone stale or are pending maintainer/committer action.
An example of a great improvement is the [CODEOWNERS](https://github.com/apache/arrow/pull/33622). This allows us to use filters like `is:pr is:open user-review-requested:@me` https://github.com/apache/arrow/pulls?q=is%3Apr+is%3Aopen+user-review-requested%3A%40me+
The above filter will show PRs that have requested a review from us.
This does not solve the problem of what are the PRs waiting for second review, waiting for changes, etcetera.
I don't think we have to reinvent the wheel, CPython has something that works well and can easily be adapted/tweaked.
They use a GitHub bot (bedevere) with the following state machine:
https://github.com/python/bedevere#pr-state-machine
PRs have one label of the following workflow labels, depending of the state:
- `awaiting review`
- `awaiting core review`
- `awaiting changes`
- `awaiting change review`
- `awaiting merge`
I would like to propose adding a GitHub bot to our repo that triggers on PR changes (commits / comments) implementing a similar workflow than the one on the CPython repository.
I am going to start working on it and I would love to hear feedback about that workflow.
### Component(s)
Developer Tools
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #33977: [Dev] Implement automation bot for PRs
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #33977:
URL: https://github.com/apache/arrow/issues/33977#issuecomment-1414525699
I'm OK with trying this workflow.
BTW, how to use https://github.com/python/bedevere in our repository? It seems that https://github.com/python/cpython/tree/main/.github/workflows doesn't have a workflow for bedevere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on issue #33977: [Dev] Implement automation bot for PRs
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #33977:
URL: https://github.com/apache/arrow/issues/33977#issuecomment-1428050371
I haven't found anything that is flexible enough to create a workflow like this one. I can see something like:
https://github.com/marketplace/actions/simplelabeler
but that only adds a label for reviewing or once the PR is approved but it doesn't add labels when we request changes, new changes have been pushed, etcetera.
The majority of actions for PR labels I am finding are more around number of reviewers/approvals, etcetera:
https://github.com/marketplace/actions/label-approved-pull-requests
I have created an initial PR with an implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #33977: [Dev] Implement automation bot for PRs
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #33977:
URL: https://github.com/apache/arrow/issues/33977#issuecomment-1419027329
I see.
Did you find a GitHub Action that provides general PR workflow automation? If it exists, we don't need to reinvent the wheel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on issue #33977: [Dev] Implement automation bot for PRs
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #33977:
URL: https://github.com/apache/arrow/issues/33977#issuecomment-1414423788
> Is a "core" dev someone that has write permissions?
Yes, on our context I was thinking that the label should be something like `awaiting committer review`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on issue #33977: [Dev] Implement automation bot for PRs
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #33977:
URL: https://github.com/apache/arrow/issues/33977#issuecomment-1418915205
They use it as an external GitHub app, not as a GitHub workflow, we could try to add an external GitHub app to reuse the `bedevere` bot itself but what I had in mind is on reusing the same state machine workflow not the bot itself.
My idea is to create a GitHub workflow that triggers an archery command (similar to our comment bot) which can manage the label addition / adding comments to the PR replicating what bedevere does. I will create a PoC on my fork and will share.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on issue #33977: [Dev] Implement automation bot for PRs
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on issue #33977:
URL: https://github.com/apache/arrow/issues/33977#issuecomment-1414410660
Is a "core" dev someone that has write permissions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd closed issue #33977: [Dev] Implement automation bot for PRs
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd closed issue #33977: [Dev] Implement automation bot for PRs
URL: https://github.com/apache/arrow/issues/33977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org